Opened 6 years ago

Closed 6 years ago

#1956 closed improve feature (fixed)

Improve the treasurer tool

Reported by: shevek Owned by: shevek
Priority: major Milestone: 1.6
Component: unknown Keywords:
Cc:

Description

The treasurer tool introduced in 1.5 is rather basic.

There are several issue & comments:

  • old entries have no edit button (editing not possible)
  • bank account balance shows surname / name the tool asks for username and checks DB, better: free text field to add/edit surname / name
  • comment section should be availibe via add/edit
  • use systemcomment column for tracking info: "Added /edited by USERNAME"

Related ticket: #1892

Change History (12)

comment:1 Changed 6 years ago by shevek

  • Summary changed from Imporve the treasurer tool to Improve the treasurer tool

comment:2 Changed 6 years ago by shevek

  • Status changed from new to assigned

comment:3 in reply to: ↑ description ; follow-up: Changed 6 years ago by shevek

  • Status changed from assigned to local_testing
  • old entries have no edit button (editing not possible)

Fixed.

  • bank account balance shows surname / name the tool asks for username and checks DB, better: free text field to add/edit surname / name

We shouldn't add that info at all. But the member field can be left empty as it is also possible to donate without being logged in. To ensure that is intentional the field has to contain -empty-. This is the predefined content of the donor field with the fix. All other content will be checked against the DB.

  • comment section should be availibe via add/edit

Added.

  • use systemcomment column for tracking info: "Added /edited by USERNAME"

Unfortunately the field is already used for the display on the donate list and contains the real info. I believe that 'Bank transfer' is enough. We would know due to the rights assignment who did the change, wouldn't we?

Commit: https://gitorious.org/bewelcome/rox/commit/793a297acacce95d08ffaef8dfa8e9faef627967

comment:4 in reply to: ↑ 3 Changed 6 years ago by crumbking

  • Status changed from local_testing to to_alpha

Replying to shevek:

  • old entries have no edit button (editing not possible)

Fixed.

  • bank account balance shows surname / name the tool asks for username and checks DB, better: free text field to add/edit surname / name

We shouldn't add that info at all. But the member field can be left empty as it is also possible to donate without being logged in. To ensure that is intentional the field has to contain -empty-. This is the predefined content of the donor field with the fix. All other content will be checked against the DB.

let's translate the AdminTreasurerDonor? to: donor username or -empty-

  • comment section should be availibe via add/edit

Added.

works and let's rename label AdminTreasurerComment?: Comment (shown public on donation list)

  • use systemcomment column for tracking info: "Added /edited by USERNAME"

Unfortunately the field is already used for the display on the donate list and contains the real info. I believe that 'Bank transfer' is enough. We would know due to the rights assignment who did the change, wouldn't we?

yepp you are right.

Commit: https://gitorious.org/bewelcome/rox/commit/793a297acacce95d08ffaef8dfa8e9faef627967

I will beauty the forms a bit. let's move to alpha.

comment:5 Changed 6 years ago by crumbking

Added yaml styles to be cross browser safe.

  • one issue: Teaser should be Edit donation while editing.

comment:6 Changed 6 years ago by shevek

Commit was: https://gitorious.org/bewelcome/rox/commit/087e776d801bbb2de0de96d4ba0c697dad3e2f3a

The date selection icon is now on a line of it's own which looks...

Teaser is now add or edit depending if edit or add: https://gitorious.org/bewelcome/rox/commit/befad5e6e72631b9a608773f9f6aa8a4160e4a3f

comment:7 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:8 follow-up: Changed 6 years ago by crumbking

I have a list with bank transfers but without any country information. Added one with country France. Asked treasurer for bank (country) info. If that doesn't work we should add a empty field. (no word this time simply empty ;-)

comment:9 in reply to: ↑ 8 Changed 6 years ago by crumbking

Replying to crumbking:

I have a list with bank transfers but without any country information. Added one with country France. Asked treasurer for bank (country) info. If that doesn't work we should add a empty field. (no word this time simply empty ;-)

Okay we need the empty country field.

comment:10 Changed 6 years ago by shevek

If I recall correctly as the DB expects an ID for the country so we can't have an empty field there (with out an additional DB change which would need to wait for 1.7).

France seems to be a good choice...

comment:11 Changed 6 years ago by shevek

Enabling no country is a bigger effort. So no chance to get that into 1.6.

Could you close this one and reopen one for the 'No country' option for 1.7?

comment:12 Changed 6 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

Added a bank transfer donation. Seems to work. Improvements go to #1985.

Note: See TracTickets for help on using tickets.