Opened 6 years ago

Closed 6 years ago

#1982 closed improve feature (fixed)

e-mail notification of forum post do not follow e-mail rules for threading and uses too much space for fixed texts

Reported by: leoalone Owned by: shevek
Priority: major Milestone: 1.7
Component: BW Mail Keywords: e-mail notification forum
Cc: shevek

Description (last modified by shevek)

  • Issue:

Forum notifications do not carry information about the thread or author of the current post in the subject. This makes threading impossible.

  • Solution:

The notification emails should carry a subject prefix and possibly "Re:" for anything but the original post in the thread. They should also carry the thread title and the author's name in the header.
It should carry a BW prefix on human readable from part, to avoid accidental address list use.


Related ticket: #2002

Attachments (3)

mailbotm.php (29.5 KB) - added by leoalone 6 years ago.
modified mailbot.php with fixes for forum post notifications
mailbot.php.diff (1.8 KB) - added by jsfan 6 years ago.
Here is a diff to save everyone else the effort…
mailbot3.php.diff (1.9 KB) - added by leoalone 6 years ago.
updated with consideration on the BW prefix on From: field

Download all attachments as: .zip

Change History (23)

Changed 6 years ago by leoalone

modified mailbot.php with fixes for forum post notifications

comment:1 Changed 6 years ago by jsfan

It's not a proper fix IMHO. You need to generate a message ID and keep and use it as In-Reply-To on the next message if you want proper threaded view. This will end up (at best) as every message being the root message's child. While that might group them together, I see relatively little benefit in this. Also, proper threaded views only make sense if there is real threading in the forum as well.

I also don't like the idea of just using the BW user name as sender. That looks a lot like spam messages. At least, it should be something like "BeWelcome (<username>)" or something along those lines.

Changed 6 years ago by jsfan

Here is a diff to save everyone else the effort...

comment:2 Changed 6 years ago by leoalone

in fact, i did not cared about the in-reply-to since the forum threads at beginning are not subthreaded, but even just having it sorted as child of first message is a great improvement, given the small cost (30 minutes of my sleep) paid. NOW it is sorted as children of the SECOND message while the first stay away. also a shorter additional field help legibility in listing. using bewelcome <username> add anyway 10 character that do not convey any additional information. and for spam filter the machine readeable part remain forum@… The benefit of this minor (and so easily testable) modification are half the possibility to sort by subject but also by author, nd half the greater qauntityof variable information diplayed in a certain screen estate.

comment:3 Changed 6 years ago by jsfan

I disagree that a prefix "Bewelcome" would not convey any additional meaning. I wasn't referring to spam filters but to human readers who a prefix like that makes more sense to. When I see an email with sender "Brad" I immediately think it is spam. We should not adopt policies that are common amongst spammers.

I have no objection as such to the "Re: " prefix other than I think it is reasonably pointless. But that's just my opinion.

comment:4 Changed 6 years ago by jsfan

  • Cc shevek added

comment:5 Changed 6 years ago by jsfan

  • Description modified (diff)

comment:6 Changed 6 years ago by jsfan

  • Description modified (diff)

comment:7 Changed 6 years ago by leoalone

I have looked at the comment of jsfan about prefixing bewelcome to the from filed. I do not like it, since actually if we have [BWG] as the beginning of subject list would be pleonastic. I have noted however that the vast majority of people that post on forum uses just the nickname, so adding BW in front of the from [and removing from the subject] would make it more balanced. I do not like it, but i posted also a mailbo33.php.diff file that has the jsfan's option . (and another tiny, invisible, correction)

comment:8 Changed 6 years ago by crumbking

Could you give an example how the subjects will look like? Thread starter and reply?

comment:9 Changed 6 years ago by leoalone

example new thread:

current one:

Date: Tue, 19 Mar 2013 22:45:05 +0100
From: forum@bewelcome.org
To: xxx@yy.zz
Subject: Forum Bewelcome, New Thread: First steps with OTRS

variant1:

Date: Tue, 19 Mar 2013 22:45:05 +0100
From: Railslide <forum@bewelcome.org>
To: xxx@yy.zz
Subject: [BWF] First steps with OTRS

variant 2(jsfan)

Date: Tue, 19 Mar 2013 22:45:05 +0100
From: BW Railslide <forum@bewelcome.org>
To: xxx@yy.zz
Subject: First steps with OTRS

reply:

Date: Tue, 19 Mar 2013 23:40:24 +0100
From: <forum@bewelcome.org>
To: xxx@yy.zz
Subject: Forum Bewelcome, Reply: First steps with OTRS

current:

Date: Tue, 19 Mar 2013 23:40:24 +0100
From: forum@bewelcome.org
To: xxx@yy.zz
Subject: Forum Bewelcome, Reply: First steps with OTRS

variant1 (leoalone preferred)

Date: Tue, 19 Mar 2013 23:40:24 +0100
From: claudiaab <forum@bewelcome.org>
To: xxx@yy.zz
Subject: Re: [BWF] First steps with OTRS

variant2 (jsfan preferred)Date: Tue, 19 Mar 2013 23:40:24 +0100

Date: Tue, 19 Mar 2013 23:40:24 +0100
From: BW claudiaab <forum@bewelcome.org>
To: xxx@yy.zz
Subject: Re: First steps with OTRS

(NOTE: actual display can vary according your reader)

comment:10 Changed 6 years ago by shevek

Regarding prefixing of sender I think we must do that. Any decent mail program will suggest from an address list and if you happen to communicate with lets say Railslide you might incidentally send a message to forum@… instead.

For that very reason postfixing isn't an option either.

comment:11 Changed 6 years ago by leoalone

good reason. i attached the diff version of the "final" one and rewritten description according the discussions made.

Changed 6 years ago by leoalone

updated with consideration on the BW prefix on From: field

comment:12 in reply to: ↑ description Changed 6 years ago by leoalone

  • Description modified (diff)

comment:13 Changed 6 years ago by shevek

  • Description modified (diff)
  • Milestone changed from unassigned to 1.7
  • Owner set to shevek
  • Status changed from new to assigned
  • Type changed from unknown to improve feature

I merge the proposed changes into mailbot.php and add the group information to the subject if that turns out to be easy (s. #2002).

comment:14 Changed 6 years ago by shevek

  • Status changed from assigned to local_testing

comment:15 Changed 6 years ago by shevek

  • Status changed from local_testing to to_alpha

comment:16 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

Please test locally using a fakemail service and calling htdocs/bw/mailbot.php airectly from the command line.

comment:17 Changed 6 years ago by dima42

works locally for me. (get from: BW henri <group@bewelcome.org> or from: BW henri <forum@bewelcome.org>)

Last edited 6 years ago by dima42 (previous) (diff)

comment:18 Changed 6 years ago by shevek

Unfortunately I realized yesterday that swift mail doesn't support sender in the given format but you have to create an address object to set the name part and address part separately.

Fixed: https://gitorious.org/bewelcome/rox/commit/502c4a1b636fc95976c607c7fb627864b21763bb

comment:19 Changed 6 years ago by shevek

Closed as fixed. With the first messages coming in from www.

comment:20 Changed 6 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.