Opened 6 years ago

Closed 5 years ago

#1987 closed bug (fixed)

Comments in groups are shown with username when logged out

Reported by: sitatara Owned by: sitatara
Priority: minor Milestone: 2.1
Component: BW Group Keywords: privacy
Cc:

Description (last modified by shevek)

When browsing the groups without being logged in, all comments left in that group can be read (there are no visibility settings for comments). The comments show up with the username of the person who left the comment, even if his/her profile is not public.

Suggested solutions:

  • Either hide the comments completely when not logged in or
  • hide the usernames of those people who have no public profile or
  • get rid of the group comments completely (this has been discussed before) and when the content is moved into a thread of the group set visibility to members only.

Related ticket #1964

Change History (11)

comment:1 Changed 6 years ago by crumbking

Support point 3. Remove it :-)

comment:2 Changed 5 years ago by shevek

  • Milestone changed from unassigned to backlog
  • Owner set to sitatara
  • Status changed from new to assigned

Just checked the DB and we had 62 comments to groups in the last 6 months and most are discussions that really should be in the group instead.

+1 for point 3. Keep the data in case someone wants to move it into the groups.

comment:3 Changed 5 years ago by shevek

  • Description modified (diff)

comment:4 Changed 5 years ago by sitatara

  • Milestone changed from backlog to 2.1

comment:5 Changed 5 years ago by sitatara

Fixed together with #1964: Group comments are now hidden by default. The group admin can make them visible in the group settings. When logged out, group comments are not shown.

http://gitorious.org/bewelcome/rox/commit/57ad6cf6fca440b4ef47efcfee3084fd9272f3e0

To hide the group comments a new column called VisibleComments was added to the table groups:

ALTER TABLE `groups` ADD `VisibleComments` ENUM( 'no', 'yes' ) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL DEFAULT 'no' COMMENT 'If comments in groups are shown or not.' AFTER `VisiblePosts`

comment:6 Changed 5 years ago by sitatara

  • Status changed from assigned to to_alpha

comment:7 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

comment:8 Changed 5 years ago by shevek

  • Status changed from testing to needs_work

There is something wrong in the admin UI for this. Even if the comments are hidden (which is the default) the UI says they are visible.

See http://alpha.bewelcome.org/groups/1582/groupsettings as an example.

comment:9 Changed 5 years ago by shevek

  • Status changed from needs_work to to_alpha

The database changes weren't done yet so feature wasn't working as expected. After DB changes applied all works fine.

comment:10 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

comment:11 Changed 5 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

Closed as fixed.

Note: See TracTickets for help on using tickets.