Opened 6 years ago

Closed 6 years ago

#2002 closed improve feature (fixed)

Add group name to the notification e-mail

Reported by: toub Owned by: shevek
Priority: major Milestone: 1.7
Component: BW Group Keywords: group, notification
Cc:

Description (last modified by shevek)

When an user receives a notification from a group, the email does not display the name of the group, se he doesn't know the origin of this post without login to bewelcome.

It should be nice to add that feature.


Related ticket: #1982

Change History (12)

comment:1 Changed 6 years ago by shevek

  • Description modified (diff)
  • Milestone changed from unassigned to 1.7
  • Owner set to shevek
  • Status changed from new to assigned
  • Type changed from unknown to improve feature

If the information in which group the post happened is easily accessible this can be done as part of #1982.

Last edited 6 years ago by shevek (previous) (diff)

comment:2 Changed 6 years ago by leoalone

The way to correct this and 1982 is not exactly the same: in the mailqueue is written a subject, but groups are treated as a forum thread. so the group name is not present in the queue, it should be written in the module that feed the queue. I try to see if for saturday i have some ispiration, but i would keep separate this part.

comment:3 Changed 6 years ago by shevek

  • Status changed from assigned to local_testing

comment:4 Changed 6 years ago by shevek

  • Status changed from local_testing to to_alpha

Please test locally using a fakemail service and calling htdocs/bw/mailbot.php airectly from the command line.

comment:5 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:6 Changed 6 years ago by dima42

works locally for me. note that i don't have fakemail entirely working so i only checked the message subject/text/from with debug strings, but this shouldn't affect the situation. i also just made up a forum_trad database with random values in order to be able to get sensible content.

comment:7 follow-up: Changed 6 years ago by shevek

Added the groupname to the subject as well to make threading more consistent: https://gitorious.org/bewelcome/rox/commit/502c4a1b636fc95976c607c7fb627864b21763bb

Subject looks like this now:

[Re: ]Thread title (group name)
Last edited 6 years ago by shevek (previous) (diff)

comment:8 in reply to: ↑ 7 Changed 6 years ago by leoalone

Not good, should appear as:

[group name] Thread title

or in case of reply

Re: [group name] Thread title

otherwise in case of long subject it is difficult to find, and more important, it become more difficult to filter (in cas onme wan tto have archived separately the various groups)

comment:9 Changed 6 years ago by shevek

At the same time putting a long group name in front of the subject might hide the information about the thread itself which I believe to be of higher interest as the post itself will contain the group name as well.

If the mailer is able to filter for '[group name]' at the beginning of the subject and in case of replies the position of the group name shouldn't matter anymore.

comment:10 Changed 6 years ago by leoalone

right. i would like , for a future release a check that if group name is less that 15 char go in front otherwise on tail. Personally i never, on any platform, made group names more than 15 characthers ... so i never thought about this. but the group name should be in square, not round brackets !

comment:11 Changed 6 years ago by shevek

Okay, fixed the brackets.

comment:12 Changed 6 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

Closed as fixed. With the first messages coming in from www.

Note: See TracTickets for help on using tickets.