Opened 6 years ago

Closed 6 years ago

#2050 closed bug (fixed)

Don't update date of comment when changing status in admin tool

Reported by: sitatara Owned by: shevek
Priority: major Milestone: 2.0
Component: BW Admin Keywords: admin, comments, sorting


If the status of a comment is changed in the "AdminComments?" tool (e.g. from "AdminAbuserMustCheck?" to "Checked"), this is counted as an update of the comment. This means, the date of the comment (last update) is changed. On the profile of the member it then shows up as an updated comment (on top of the list of latest comments). That should not happen. Changes to the admin status of comments should not be visible outside of the AdminComments? tool in any way nor have any effects on the comment sorting on profiles (and inside the admin tool).

Therefore, please don't change the date of of a comment (last update) when only the status of a comment is changed inside the admin tool. The possible statuses are: AdminCommentMustCheck?, AdminAbuserMustCheck?, Checked, NothingNeeded?.

Change History (9)

comment:1 Changed 6 years ago by sitatara

  • Milestone changed from unassigned to 2.0
  • Owner set to shevek
  • Status changed from new to assigned

comment:2 Changed 6 years ago by shevek

Deployed to alpha. Can't be tested as the following DB update is needed:

ALTER TABLE  `comments` CHANGE  `updated`  `updated` TIMESTAMP NULL DEFAULT NULL ;

Checks needed after release.

comment:3 Changed 6 years ago by shevek

  • Status changed from assigned to to_alpha

comment:4 Changed 6 years ago by shevek

  • Status changed from to_alpha to testing

comment:5 Changed 6 years ago by Tsjoek

I have tested this locally after making the db-update and it seems to me that this has been changed a bit too thoroughly:

The ticket asks for not updating the date when only the adminstatus is changed by a moderator. I think now it never updates the date anymore. I have changed the text of the comment as an admin and it doesn't change (should it or not?). But also when I changed a comment as a normal member, the date didn't change in the db, and the update didn't show up in the receivers "what's happening", something that used to happen before.

When changing as an admin I didn't get the message that Swiftmailer is not installed, and I do get that when changing as a normal member. So I assume that no notification is sent when changing as an admin, but one is sent when changing as a member. That seems alright to me.

comment:6 Changed 6 years ago by shevek

Forgot to commit some code. I did that now. Code is deployed to www already so you can test live.

comment:7 Changed 6 years ago by sitatara

I tested it and it works now (date now updates for regular edits but not for admin edits). @Tsjoek: I already deleted your test comment again. Feel free to post it again to test this too.

comment:8 Changed 6 years ago by Tsjoek

Yeah, as far as I can see, looking better now.

comment:9 Changed 6 years ago by sitatara

  • Resolution set to fixed
  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.