Opened 5 years ago

Closed 5 years ago

#2058 closed improve feature (fixed)

Improved errorhandling for IE on statspage

Reported by: Tsjoek Owned by: Tsjoek
Priority: major Milestone: 2.0
Component: unknown Keywords: stats
Cc:

Description

IE6/7/8 doesn't support canvas and doesn't render the stat graphs nor shows an errormessage. At least an errormsg is close at hand, so let's do that.

Change History (16)

comment:1 Changed 5 years ago by Tsjoek

  • Status changed from new to local_testing

Added the errormsg for non-canvas browsers. That is not going to improve it for IE9/10 probably, but solution there is more difficult. The whole page needs a complete rework anyway. Later.

comment:2 Changed 5 years ago by shevek

  • Status changed from local_testing to to_alpha

I wasn't happy with the fact that the statistics pages aren't visible to a (assumed) majority of members. Therefore implemented a solution based on pchart (version 2.1.3) which uses the GD image library to generate graphs.

See commit: https://www.gitorious.org/bewelcome/rox/commit/3fed73d851d0182c0261dcc512749e4f62d66b07

comment:3 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

Deployed on Alpha.

comment:4 Changed 5 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

comment:5 Changed 5 years ago by shevek

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:6 Changed 5 years ago by shevek

  • Status changed from reopened to to_alpha

comment:7 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

comment:8 Changed 5 years ago by shevek

  • Milestone changed from unassigned to 2.0
  • Priority changed from minor to major
  • Type changed from unknown to improve feature

comment:9 Changed 5 years ago by crumbking

The green color in the stats are horrible ;-) maybe some BW orange? Also the white background looks not really nice maybe we could change it to the background grey.

Besides this minor stuff it works. Language translations are missing.

comment:10 Changed 5 years ago by shevek

Colors: Agreed :-) I just wanted to see it before fiddling with details.

Translation was always missing (and would in this case mean we need to generate the graphics for all languages) but I could get rid of the axis label so that less translation is wrong...

Last edited 5 years ago by shevek (previous) (diff)

comment:11 Changed 5 years ago by shevek

Just committed an update and pushed an update to alpha. Please check tomorrow :-)

Changes. Different color (still not the one I like). Use English language names for the statistics and rename PofileLangStats? to PreferredLangStats?.

comment:12 Changed 5 years ago by crumbking

  • pic below "PreferredLangStats" is no visible in IE8/WIN7
  • the legend does not render some "non latin chars?!?" in the cake "StatsLanguages" (language below svenska and below türkce)

comment:13 Changed 5 years ago by shevek

As I said, check tomorrow. The stat pics where already generated for today when I push the changes. Should be all good (at least better) in some hours ;-´).

comment:14 Changed 5 years ago by crumbking

Looks good. Maybe the white background behind the pie sharts. Quite suprised by the browsing languages. Does that mean most people use the page in English?

comment:15 Changed 5 years ago by shevek

The assumption on my side regarding the browsing languages is that if you never set any of your preferences you end up with English as the default language. As that is true for quite a few people most people likely visit the site in English.

I once did a check on the database regarding Greek and found 23 members having set that language.

I make the pie chart background transparent as well.

comment:16 Changed 5 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

Statistics page is live now. IE 10 shows the results just fine.

Note: See TracTickets for help on using tickets.