Opened 10 years ago

Closed 10 years ago

#207 closed bug (fixed)

Profile picture size is huge

Reported by: ocal5 Owned by: lemon-head
Priority: minor Milestone: 0.1.3
Component: BW Profile Keywords: Profile picture display
Cc:

Description

Instead of using the "square.50x50.jpg" version of picture, the little one who is display on top left, when we are on http://alpha.bewelcome.org/main, use a browser-resized version of the full picture... so it loads & use in worst cases 300 KB of bandwidth !

It's going to kill 56K users, and I don't speak about GPRS ones :D

I think it's not too hard to fix it, because resized pictures are already use in actual production BW.

Thanks

Change History (16)

comment:1 Changed 10 years ago by philipp

  • Milestone set to 0.1.1-outreach-bugfixing

comment:2 Changed 10 years ago by lemon-head

  • follow_up set to none

Same applies to forum avatars!

comment:3 Changed 10 years ago by lemon-head

  • follow_up changed from none to test
  • Owner set to lemon-head
  • Status changed from new to assigned

should be fixed with [3691] - please test!

comment:4 Changed 10 years ago by micha

  • Milestone changed from 0.1.1-outreach-bugfixing to 0.1.2 - more improvements & bugfixing

comment:5 Changed 10 years ago by midsch

on test, alpha & production the image size is the same: big original, not resized.

comment:6 Changed 10 years ago by micha

  • follow_up changed from test to none

comment:7 Changed 10 years ago by micha

  • follow_up changed from none to move to alpha

This is far better, Andreas. I didn't find any errors. But in my opinion we should also stop to use a 100x100px thumb or at least offer another one with 50x50px. Otherwise the pictures still will look very ugly.

But again, your code is a very good step! I suggest moving it to alpha for now.

comment:8 Changed 10 years ago by matrixpoint

  • follow_up changed from move to alpha to test on alpha

Moved to alpha in r3722.

comment:9 Changed 10 years ago by ocal5

I can't check on forum (it seems good regarding other comments... but I get an error message right now), but top left picture on homepage is still in full definition on alpha

comment:10 Changed 10 years ago by matrixpoint

The homepage picture wasn't working because two files from r3700 are also needed. Moved to alpha in r3725.

comment:11 Changed 10 years ago by matrixpoint

These are the five files needed:

modules/layoutbits/lib/layoutbits.lib.php
templates/apps/forums/singlepost.php
templates/apps/forums/topic.php
build/rox/rox.view.php
templates/apps/rox/teaser_main.php

The first one was already moved to alpha.

comment:12 Changed 10 years ago by matrixpoint

I notice the error on the main page:

Warning: Missing argument 1 for RoxView::volunteerBar(), called in /home/bwrox/alpha.bewelcome.org/build/rox/rox.ctrl.php on line 299 and defined in /home/bwrox/alpha.bewelcome.org/build/rox/rox.view.php on line 117

This is because changes that were part of another ticket (r3689) were made to rox.view.php before the changes in the version moved to alpha for this ticket. The error would go away if I moved rox.ctrl.php now, but it's needed to get the picture working, and the other changes in it haven't been tested yet.

I think this kind of problem will happen repeatedly with many developers unless locking is used.

comment:13 Changed 10 years ago by matrixpoint

but it's needed to get the picture working -> but it's NOT needed to get the picture working

comment:14 Changed 10 years ago by micha

  • follow_up changed from test on alpha to release

seems to work now. Can still be improved but is far better than our online version. Go for release!

comment:15 Changed 10 years ago by matrixpoint

build/rox/rox.model.php
build/rox/rox.ctrl.php
build/rox/rox.view.php
modules/layoutbits/lib/layoutbits.lib.php
templates/apps/rox/teaser_main.php

moved to production in r3767

comment:16 Changed 10 years ago by matrixpoint

  • follow_up changed from release to none
  • Resolution set to fixed
  • Status changed from assigned to closed
  • version changed from alpha to production

Note put in #305 to include templates/apps/forums/singlepost.php and templates/apps/forums/topic.php from #207 and r3691 along with the other forum files in this ticket. They call $words->getBuffered() in modules/i18n/lib/words.lib.php which isn't ready yet. The main goal of #207 (the thumbnail picture on the main page) was achieved, so closing now.

Note: See TracTickets for help on using tickets.