Opened 9 years ago

Closed 9 years ago

#208 closed bug (fixed)

Members Status to procceed at login

Reported by: jeanyves Owned by:
Priority: major Milestone: 0.1.4
Component: BW General Keywords: login member status
Cc: steinwinde, micha

Description

This ticket is just open reading the code of bwauthlib

According to the current status of the member at login the following is to be done :

  • Pending : refuse login and provide a message : your subscription is not yet accepted, please wait a bit you will receive a mail when yit will be (there is an existing word for this : ApplicationNotYetValid?)
  • CompletePending? : refuse login and provide a message : (new word to create) : you have competed your profile, please wait a bit we need to review your data
  • ChoiceInactive? (This happen when a member has set his status to inactive not to be visible by default in the search result) prompt the use with a message to warn him his profile is now Active again, set his status to "Active", accept the login
  • NeedMore? : according to my test this case works as expected, the member is logged, redirected to the UpdateMandatory? page and proposed to complete his profile, when he validate his sstatus is set to 'Pending' (it should be CompletePending?, but it is not a big problem)
  • Banned : a message "You cannot use BeWelcome anymore bcause you have been banned" should be displayed and logon refused
  • Takenout : a message "You cannot use BeWelcome anymore bcause you have ask to leave bewelcome" should be displayed and logon refused

Very important, don't forget to log action with the LogStr?() function or its new rox vrsion according to each of these action, this can help the support team and teh debugging. If possible, use exatcly the same sentence as per old BW code (to haev consistant log because they are almost 2000 members who haev used old BW code )

Change History (11)

comment:1 Changed 9 years ago by jeanyves

  • Cc steinwinde micha added
  • follow_up set to none
  • Priority changed from major to blocker
  • version set to all

I think this ticket is critical

At least the members with Pending statute when they try to log should see displayed the content of the word : ApplicationNotYetValid? (which already exist and is already translated).

This is probably to do in bwauth.lib.php

In addition a Log : LogStr?("Member #".$m->id." is trying to log while in status ".$m->Status." Log has failed","Login") ;

can someone check the bwauth.lib.php in test and add what is needed to diplay the content of word ApplicationNotYetValid? instead of the current login failed ?

comment:2 Changed 9 years ago by steinwinde

  • Owner set to steinwinde
  • Status changed from new to assigned

comment:3 Changed 9 years ago by steinwinde

Just for the record (local test based on trunk r3605):

After the click on the confirmation link in the e-mail, the user just sees a page, where she can edit her profile. Instead we need a message, something like "Thank you for confirming your application. We'll get back to you. If you want, feel free to complete your profile."

After the candidate submits this profile page, she just gets logged off and sees the front page of www.bewelcome.org. That's neither nice.

When she nows tries to log on, she gets a white page with this error message in black:

Notice: Undefined property: stdClass::$username in /home/felix/hospitality/bw/trunks/2007-12-13T23-27-08/modules/user/lib/bwauth.lib.php on line 189

Warning: Cannot modify header information - headers already sent by (output started at /home/felix/hospitality/bw/trunks/2007-12-13T23-27-08/modules/user/lib/bwauth.lib.php:189) in /home/felix/hospitality/bw/trunks/2007-12-13T23-27-08/lib/handler/posthandler.lib.php on line 70

comment:4 Changed 9 years ago by steinwinde

See also #217.

comment:5 Changed 9 years ago by micha

Just commited a fix. Please test!

comment:6 Changed 9 years ago by steinwinde

  • Component changed from BV Forum to BW General
  • Owner steinwinde deleted
  • Status changed from assigned to new

Jean-Yves and Micha take over.

comment:7 Changed 9 years ago by jeanyves

  • follow_up changed from none to test

I don't know what is the exact situation for this ticket

I mess with Felix (Apologize) when I added Logs in bwauth.lib.php (my change can be overwritten, not a problem).

I have make a fix in test (it was only a bug in test) to solve the problem Micha and me have had whene we were trying to signup on test.bewelcome.org (we had a bad memberkey error message).

I would like to proceed quicly with this 208 ticket since it is currently a pain for the new BW members who are subscribing on Live.
They are several points :

  • the bwauth.lib.php which should display a clear information when a member at status Pending try to log in
  • the editprofile where we have worked on with Micha

I proposed to commit the editprofile in Alpha and test it and then try to analyse if it can be a benefit right now for production

comment:8 Changed 9 years ago by micha

  • Milestone changed from 0.1.1-outreach-bugfixing to 0.1.2 - more improvements & bugfixing

mostly fixed. moving to new 0.1.2 to keep track.

comment:9 Changed 9 years ago by jeanyves

This is not yet completely fix IMHO two main things are missing :

  • A page telling you must confirm your mail before loggin in which a new member should see if he has not yet confirm his mail (he will then not try to subscribe a second profile ...)
  • #389 : a redirection to the initial query when the user was sent to the loginn in page because he wants to see something on a url wich require him to be logged in.

comment:10 Changed 9 years ago by lemon-head

  • freq_reported set to 1
  • Priority changed from blocker to major
  • show_on_bw set to 0

As this is said to be 'mostly fixed', I think we can change the priority to 'major'.

comment:11 Changed 9 years ago by philipp

  • Resolution set to fixed
  • Status changed from new to closed

ok - whenever touching login we have to be careful about this - anyhow I think we can close this ticket

Note: See TracTickets for help on using tickets.