Opened 5 years ago

Closed 5 years ago

#2101 closed improve feature (fixed)

Add possibility to mark translation as minor change

Reported by: shevek Owned by: Tsjoek
Priority: major Milestone: 2.3
Component: BW Internationalization Keywords:
Cc:

Description

With the upcoming change that English will supersede any translation if the English version is newer a possibility to mark a change as minor is needed. Otherwise every fixed typo in English will lead to a lot of work for the translators.

Change History (10)

comment:1 Changed 5 years ago by Tsjoek

  • Owner set to Tsjoek
  • Status changed from new to assigned

comment:2 Changed 5 years ago by shevek

  • Milestone changed from 2.2 to 2.3

Moved to 2.3.

comment:3 Changed 5 years ago by Tsjoek

On each update in English, user needs to choose between minor and major, to prevent accidents. See #2107 for db updates.

comment:4 Changed 5 years ago by shevek

  • Status changed from assigned to to_alpha

comment:5 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

Deployed to alpha.

comment:6 Changed 5 years ago by sitatara

There is some issue with this: I just updated the English wordcode "Donate_WhyText" as minor change (twice). The German translation was kept (so that's fine), showed up as changed for me as translator (also fine although I would prefer another color than for major changes to differentiate minor and major more easily - I know the language is the best indicator but it seriously confused me). However, after I clicked on the German translation to update it, and submitted the unchanged translation, the German text still shows up as a text that needs a minor update (i.e. it is still marked as text that needs an updated translation).

PS: The "This is ok" button does the trick though.

Last edited 5 years ago by sitatara (previous) (diff)

comment:7 Changed 5 years ago by sitatara

Another problem: When I change the text of an FAQ through the FAQ admin tool (and not through admin words) this seems to be automatically assumed as minor edit (which it is not necessarily - right now for example, I am making major changes).

comment:8 Changed 5 years ago by Tsjoek

Fixed both with: https://www.gitorious.org/bewelcome/rox/commit/d08d24c9172ae4ecebc1c6a53b935846fb307fde

Regarding the extra color separation: I'm personally not a fan of that. It doesn't make things easier for beginner translators, and the action needed in both cases is exactly the same: spot the difference and make corrections as needed. As you noted the more experienced translators can see the difference on the language anyway (in most cases).

comment:9 Changed 5 years ago by sitatara

Thanks! Both is working well on alpha now. However, I am not forced to decide if it is a minor or major change in the FAQ tool and if I choose none of the two options it is just assumed to be a minor change. I'd prefer this to be a forced choice (as for all other word codes).

As for colors: I'll get used to it. ;-)

comment:10 Changed 5 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

FAQ should go in a new ticket. this is done.

Note: See TracTickets for help on using tickets.