Opened 5 years ago

Closed 5 years ago

#2145 closed new feature (fixed)

ToU: Implement silent membership

Reported by: shevek Owned by:
Priority: critical Milestone: 2.3
Component: BW Profile Keywords:
Cc:

Description

The status used in Rox is 'ChoiceInactive?'.

The following needs to be done:

  • Don't switch a 'ChoiceInactive?' profile to 'Active' after login.
  • Don't show any data of silent members anywhere (remove 'ChoiceInactive?' status from status lists; hide profile in searches; show message that profile is silent but no profile data)
  • Allow members to switch back to 'Active' (switch back to silent is limited)

Change History (10)

comment:1 Changed 5 years ago by shevek

  • Status changed from new to local_testing

Database update needed to store the last time the user switched to 'ChoiceInactive?':

ALTER TABLE  `members` CHANGE  `SecurityFlag`  `LastSwitchToActive` DATETIME NULL 
DEFAULT NULL COMMENT  'Stores the last time profile was set to ''Active''. 
Needed to limit switches between ''ChoiceInactive'' and ''Active''.';

First Commit (column name 'LastActiveSwitch?'): https://gitorious.org/bewelcome/rox/commit/75e90ec72f9db541c87ffc2892c9fe9a064a59cc

Second commit (new column name 'LastSwitchToActive?'): https://gitorious.org/bewelcome/rox/commit/3e5bf880915359ea54b91c3f6ca346827103a57b

Last edited 5 years ago by shevek (previous) (diff)

comment:2 Changed 5 years ago by shevek

  • Status changed from local_testing to to_alpha

comment:3 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

Deployed to alpha. For testing purposes the time frame for switches is 1 day while it is planned to be 14 days when it goes live.

comment:4 Changed 5 years ago by crumbking

I don't like the new menu entry below the "delete profile" menu entry under the edit profile page.

Why should we introduce a new menu entry under edit profile page? If I want to delete my profile I would never come to the idea to look under the edit profile page. Same for the silent membership. I would search for some kind of setting.

Suggestion:

  • move delete/silent membership pages into the my preferences page.
  • rename: "My preferences" to "Settings"
  • introduce a tab view (like in edit profile page): privacy settings, account settings, discussion settings
  • move the relevant preferences into the setting tabs

Much more clean and straight forward to find via main menu.

comment:5 Changed 5 years ago by shevek

@crumbking: I'd refrain from reorganizing everything :-)

Delete profile was always only visible when you went to edit my profile (never understood that either). Splitting the two possible options (delete, set inactive) into separate menu items should lead to less confusion for the users.

comment:6 Changed 5 years ago by crumbking

Okay future thing ;-)

comment:7 Changed 5 years ago by sitatara

While I agree with you, crumbking, I think what you suggest would deserve a new improvement ticket. For me, the scope of this ticket has been fulfilled. The task was to split deactivation from deletion and that was done in the same place where both options have been located before as well.

Anyway, I tested the changes and deletion and deactivation works as expected, reactivation works fine as well and another change to inactive is only possible two weeks later (that one I did not test :-)). The deactivated profiles are no longer visible to others (except Safety Team). Voting and ranking is no longer possible when inactive but it's currently still possible to post in forums, blogs, trips - that does not make much sense to me (but was not clearly specified, I have to admit ;-)).

comment:8 Changed 5 years ago by shevek

As a first step removed new topic buttons for new forum posts.

comment:9 Changed 5 years ago by planetcruiser

i just noticed, http://www.bewelcome.org/online always shows an empty list.

replacing "self::ACTIVE" with "Member::ACTIVE_ALL" in build/online/online.model.php will fix this.

incriminating commit was: https://gitorious.org/bewelcome/rox/commit/75e90ec72f9db541c87ffc2892c9fe9a064a59cc

comment:10 Changed 5 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

works on alpha

Note: See TracTickets for help on using tickets.