Opened 4 years ago

Last modified 3 years ago

#2155 new improve feature

Improve AdminComment

Reported by: Tsjoek Owned by: steinwinde
Priority: minor Milestone: unassigned
Component: BW Admin Keywords:
Cc:

Description (last modified by Tsjoek)

A ticket to collect possible improvements to the AdminComment module.

  • when a comment has been processed, offer option to send notification.
  • probably easier to migrate it into Rox
  • improve layout

Related: #2033

Attachments (1)

44.png (59.9 KB) - added by crumbking 3 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by Tsjoek

  • Description modified (diff)

comment:2 Changed 4 years ago by Tsjoek

  • Description modified (diff)

comment:3 Changed 3 years ago by steinwinde

  • Owner changed from Tsjoek to steinwinde
  • Status changed from new to assigned

I'm migrating AdminComment? into Rox, i.e. into /build/admin.

comment:4 Changed 3 years ago by crumbking

  • Milestone changed from unassigned to 2.6

comment:5 Changed 3 years ago by crumbking

on http://bw/admin/comments/list?action=showAll

I get a couple of errors:

  • Notice: Undefined variable: total_bad_comments in /home/crumb/webdev/bw/build/admin/comments/templates/admincomments.column_col3.php on line 61
  • Notice: Undefined index: from in /home/crumb/webdev/bw/build/admin/comments/admincomments.ctrl.php on line 66
  • Notice: Undefined index: to in /home/crumb/webdev/bw/build/admin/comments/admincomments.ctrl.php on line 67

Changed 3 years ago by crumbking

comment:6 Changed 3 years ago by crumbking

see attached the layout breaks out. (my guess some missing closing divs)

comment:7 Changed 3 years ago by steinwinde

With #878f921 there's a working version of the Admin comments app in Git. It has the following limitations:

  • insufficient testing
  • after every update of a comment, the changed comment is displayed - and not the comment as part of a list of other comments
  • the updates use HREF/GET and SUBMIT/POST; better would be BUTTON/POST
  • the new implementation might not write exactly the same log entries as the old one; this should be checked especially in case of failed updates

comment:8 Changed 3 years ago by shevek

  • Cc sitatara removed
  • Milestone changed from 2.6 to 2.7
  • Status changed from assigned to new

Moving to 2.7 as the code isn't accessible yet and needs some updates.

comment:9 Changed 3 years ago by beatnickgr

  • Milestone changed from 2.7 to unassigned

Unassigned, as crumbking requested.

Note: See TracTickets for help on using tickets.