Opened 5 years ago

Closed 5 years ago

#2166 closed improve feature (fixed)

Remove restriction icons from profile

Reported by: shevek Owned by:
Priority: minor Milestone: 2.4
Component: BW Profile Keywords:
Cc:

Description

As decided for the suggestion ' Restrictive icons on the profile, and searchable restrictions' (http://alpha.bewelcome.org/suggestions/35/results) remove the restriction icons and cleanup the layout for other restrictions.

Change History (10)

comment:1 Changed 5 years ago by shevek

  • Status changed from new to local_testing

Removed restriction icons. Cleanup of restriction section. Other restriction is now part of restrictions. In edit profile the checkbox 'Other restrictions' was removed. If you enter something in Other restrictions it will be shown.

Commit: https://www.gitorious.org/bewelcome/rox/commit/e2521f1e6aa2ac1f67c1cee6a105cadacf690e7a

comment:2 Changed 5 years ago by crumbking

  • Status changed from local_testing to to_alpha

wonder if we really need a new line for every restriction. Anyway seems to work. Let's move to alpha. Let's to not add to much new stuff. Better get this into the wild soon...

comment:3 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

I kept the new line as it was (but removed a comma). Especially as the other restrictions would need to have a new line to set them off from the rest.

Deployed to alpha.

comment:4 Changed 5 years ago by shevek

Removed restriction icons from (new) search results as well.

comment:5 Changed 5 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

works

comment:6 Changed 5 years ago by shevek

  • Resolution fixed deleted
  • Status changed from closed to reopened

Changed some code (only show label at least one restriction is set; removed line breaks; added '.' at the end).

Back to testing.

comment:7 Changed 5 years ago by shevek

  • Status changed from reopened to to_alpha

comment:8 Changed 5 years ago by shevek

  • Status changed from to_alpha to testing

comment:9 Changed 5 years ago by leoalone

found now that is on www three more bugs, not severe but nevertheless bugs:

  • if one select to offer dinner and guided tour the two "offerings" are separated by a comma but appears with uppercase initial; the second one should appear lowercase. in case it would be inconvenient to haev a specific rule, better all lowercase.
  • there is an additional white line below that ones and the rest of the content.
    If one want a blank line should put it the editable text.
  • these two item are in english even if the rest of the profile is in another language.
  • House rules is untranslated.
  • on the profile edit page it is still "other restrictions" and not "house rules"
Last edited 5 years ago by leoalone (previous) (diff)

comment:10 Changed 5 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

Fixed the text on the profile edit page.

The rest is left as is. (Missing translation isn't an issue. The plank line is intentional as are the capitals (coming through the translation),)

Note: See TracTickets for help on using tickets.