Opened 4 years ago

Closed 4 years ago

#2204 closed improve feature (fixed)

Unify email validation

Reported by: shevek Owned by: shevek
Priority: major Milestone: 2.6
Component: BW Signup Keywords:
Cc:

Description

Different code areas use different regular expressions to validate email addresses. This should be unified to use the same validation procedure.

Using filter_var is probably a good idea.

Change History (16)

comment:2 Changed 4 years ago by shevek

  • Status changed from new to local_testing

comment:3 follow-up: Changed 4 years ago by crumbking

The email text in the invite form with wysiwyg editor is unformatted now. It should be ready for sending without doing any formatting (like before)

comment:4 Changed 4 years ago by Tsjoek

@crumbking: wrong ticket?

comment:5 Changed 4 years ago by shevek

  • Status changed from local_testing to to_alpha

comment:6 Changed 4 years ago by shevek

  • Status changed from to_alpha to testing

comment:7 Changed 4 years ago by shevek

  • Status changed from testing to alpha

comment:8 Changed 4 years ago by shevek

  • Status changed from alpha to testing

comment:9 Changed 4 years ago by Tsjoek

I cannot change my emailaddress on beta to something that contains a '+' in the username part. The address I tried is accepted by php's filter_var, so somewhere is still a custom regex active.

@myself in comment 4: I see now the connection between crumbking's remark and this ticket.

comment:10 Changed 4 years ago by shevek

Fixed the validation error by changing !PFunctions::isEmailAdress: https://gitorious.org/bewelcome/rox/commit/c38d416fd7fff6e27e034cf18975e8d6d21afd61

comment:11 in reply to: ↑ 3 Changed 4 years ago by shevek

Replying to crumbking:

The email text in the invite form with wysiwyg editor is unformatted now. It should be ready for sending without doing any formatting (like before)

Just checked the code and can't see what's referred to hear. The text from the input field is taken as is and put into the invite message. Might have been changed with one of the other tickets in the mean time?

comment:12 Changed 4 years ago by shevek

Deployed to beta.

comment:13 Changed 4 years ago by crumbking

I checked on beta with and without wysiwyg editor. With email preference HTML mails. Works now. Maybe another test without html preference needed?

Oh and what's the reason we removed the profile pic option?

comment:14 Changed 4 years ago by shevek

The HTML mail preference has no impact here as it is about receiving message from BW when your a member. It is not taken into account when sending invites.

From the code I'd say that pic option never worked, so I dropped it (when kind of, the function parameter for attachments is still there).

comment:15 Changed 4 years ago by Tsjoek

Changing the emailaddress in the profilesettings seems to work properly now.

comment:16 Changed 4 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

all good I would say...

Note: See TracTickets for help on using tickets.