Opened 4 years ago

Closed 4 years ago

#2223 closed bug (fixed)

Password can not contain special characters

Reported by: shevek Owned by: Tsjoek
Priority: major Milestone: 2.6
Component: BW Profile Keywords:
Cc:

Description

A user reported a problem changing his password. This seems to be due to a ' in the password.

Change History (17)

comment:1 Changed 4 years ago by Tsjoek

  • Owner set to Tsjoek
  • Status changed from new to assigned

comment:2 Changed 4 years ago by Tsjoek

  • Status changed from assigned to local_testing

Streamlining the passwordprocess by using the same functions for it everywhere should solve the issue.

https://www.gitorious.org/bewelcome/rox/commit/771647a22675ff0185cb5a1fc98156bdbcc3b887

comment:3 Changed 4 years ago by shevek

  • Status changed from local_testing to needs_work

Changing to a password containing a ' is now possible. Unfortunately changing a password containing a ' isn't.

comment:5 Changed 4 years ago by Tsjoek

  • Status changed from needs_work to local_testing

comment:6 Changed 4 years ago by shevek

Just tested again and it still fails. For whatever reason members.model.php isn't updated while the commit shows an update.

comment:7 Changed 4 years ago by shevek

  • Status changed from local_testing to new

comment:8 Changed 4 years ago by shevek

  • Status changed from new to assigned

comment:9 Changed 4 years ago by shevek

  • Status changed from assigned to to_alpha

comment:10 Changed 4 years ago by shevek

  • Status changed from to_alpha to needs_work

comment:11 Changed 4 years ago by Tsjoek

For one reason or another the initial fix for 2230 reversed the changes for this ticket in the members.model. I tried again with:

https://www.gitorious.org/bewelcome/rox/commit/807d938271869eed8aba6e813168d4590004620a

comment:12 Changed 4 years ago by shevek

  • Status changed from needs_work to to_beta

Works now.

comment:13 Changed 4 years ago by shevek

There was a problem with the signup process where the password wouldn't be saved correctly.

https://gitorious.org/bewelcome/rox/commit/11fe06f2041a2b2406d65849b8c9dd40a3860ddd

comment:14 Changed 4 years ago by shevek

  • Status changed from to_beta to testing

comment:15 Changed 4 years ago by crumbking

On preference page there is no user feedback if a password change worked. So a green flash should show up. (off topic)

I changed a password to %36$pCaY&oo'` and this worked. Anything else to test here?

comment:16 Changed 4 years ago by shevek

Looks good to me. The password change never had any feedback, that really should be changed. Could you please open a ticket?

comment:17 Changed 4 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

all good

follow up ticket for user feedback: #2246

Note: See TracTickets for help on using tickets.