Opened 4 years ago

Closed 4 years ago

#2224 closed improve feature (fixed)

Handling groupmember admin functions incorrect

Reported by: Tsjoek Owned by: Tsjoek
Priority: trivial Milestone: 2.6
Component: BW Group Keywords:
Cc: shevek

Description

After accepting/kicking/banning etc. a member the groupadmin gets redirected to the group overview page, which is unpractical if there are several applications. The page also shows as if the member is not groupadmin, until reloaded. Also some actions are confirmed with a flashmessage, others are not.

It should end on the membersadmin page instead for every action (except resign as admin), and be confirmed with a flash note in any case.

Change History (10)

comment:1 Changed 4 years ago by Tsjoek

comment:2 Changed 4 years ago by Tsjoek

  • Status changed from new to local_testing

comment:3 Changed 4 years ago by crumbking

On the page: bw/groups/77/memberadministration

I get:

Warning: Creating default object from empty value in bw/build/groups/groups.ctrl.php on line 641

comment:4 follow-up: Changed 4 years ago by crumbking

After kicking a member you end up on this url: bw/groups/77/kickmember/932

If you then go to the next page 2 you end up on: bw/groups/77/kickmember/932/page/2 which is actually bw/groups.

I would suggest to redirect to bw/groups/77/groupsettings to not get in trouble with the pagination.

comment:5 in reply to: ↑ 4 Changed 4 years ago by Tsjoek

Replying to crumbking:

After kicking a member you end up on this url: bw/groups/77/kickmember/932

If you then go to the next page 2 you end up on: bw/groups/77/kickmember/932/page/2 which is actually bw/groups.

Right, that's an issue.

I would suggest to redirect to bw/groups/77/groupsettings to not get in trouble with the pagination.

I still prefer to stay at memberadministration, as that is where you are anyway (and you may want to do some more actions). I've now redirected the page all the way to the memberadministration in stead of just building the page with the data.

https://www.gitorious.org/bewelcome/rox/commit/0f835ec0f8673a627af3c3ec89f38a0ff27e6c48

Regarding the empty object warning: there's a couple of hundred more in rox, I already hardly notice them anymore (just like those for mysql_*). I don't think creating more or less empty classes for each individual case will bring us a lot, so we should do then something on toplevel, but that is way out of scope for this ticket.

comment:6 Changed 4 years ago by shevek

  • Status changed from local_testing to to_alpha

comment:7 Changed 4 years ago by shevek

  • Status changed from to_alpha to testing

Deployed to alpha.

comment:8 Changed 4 years ago by shevek

  • Status changed from testing to alpha

comment:9 Changed 4 years ago by shevek

  • Status changed from alpha to testing

comment:10 Changed 4 years ago by crumbking

  • Resolution set to fixed
  • Status changed from testing to closed

Works

Note: See TracTickets for help on using tickets.