Opened 10 years ago

Closed 4 years ago

Last modified 4 years ago

#235 closed improve feature (fixed)

Your comments - a way to see the comment you have made

Reported by: jeanyves Owned by: shevek
Priority: major Milestone: 1.5
Component: BW Profile Keywords: comments
Cc:

Description

I think it is needed to provide a way for the user to see all the comment he has written.
This will increase the will of the member to put comments on other people.

Wether the comment someone has made should be visible grouped on the same page for other users is may be also needed. Anyway, may be this point need debates ? I don't know

Attachments (5)

bw_comments.png (71.9 KB) - added by shevek 5 years ago.
Comments overview
border_left_top.png (89.1 KB) - added by crumbking 5 years ago.
double grey line.png (76.2 KB) - added by crumbking 5 years ago.
solid_double_line.png (82.5 KB) - added by crumbking 5 years ago.
patch235.diff (773 bytes) - added by shevek 4 years ago.
Add a 'Add Comment' button to unreplied comments (updated)

Download all attachments as: .zip

Change History (64)

comment:1 in reply to: ↑ description Changed 10 years ago by jeanyves

Replying to jeanyves:

I think it is needed to provide a way for the user to see all the comment he has written.
This will increase the will of the member to put comments on other people.

Wether the comment someone has made should be visible grouped on the same page for other users is may be also needed. Anyway, may be this point need debates ? I don't know

Complement : I say This will increase the will of the member to put comments on other people because then several people will see if they look to there list that they haven written comments about several people they know and may be that they are not thinking about.

comment:2 Changed 5 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:3 Changed 5 years ago by midsch

  • Milestone set to unassigned
  • Resolution set to fixed
  • Status changed from new to closed

This is done on https://www.bewelcome.org/members/$username/comments now, it's possible comments recieved and written. (Any further improvent here should go with a rewrite of the comments in Welen)

comment:4 Changed 5 years ago by sitatara

  • Resolution fixed deleted
  • Status changed from closed to reopened

The comments page only shows the received comments and the own "replys" but not the comments one left without ever receiving a reply to them.
To check out what I mean, please go to http://www.bewelcome.org/members/sitatara/comments and then have a look here for a few comments I left but which are not listed on my comments page:

Changed 5 years ago by shevek

Comments overview

comment:5 Changed 5 years ago by shevek

  • Milestone changed from unassigned to 1.5
  • Owner set to shevek
  • Status changed from reopened to assigned

I have a fix ready for this. The only open question I have is how to sort the left comments that didn't get a reply into the list. Just put them to the end of the list or put them into the timeline?

Comments overview

comment:6 Changed 5 years ago by midsch

I'd prefer showing these comment without "answers" in the timeline. In a way that also tells a story and the development of a profile over a period of time is something useful. (Right now a lot of these comments may result from moving stuff from other networks to BW, but on the long run the timeline tells more than just adding the comments down below the others.)

comment:7 Changed 5 years ago by shevek

Another thing I'm wondering about is if we should hide the avatar if no comment was written yet? Or remove the light grey in the back. Something to make the box different to a real comment box.

comment:8 Changed 5 years ago by midsch

Leave the avatar, the link to the profile and the info is useful. But removing the grey background to make it look different is good.

comment:9 Changed 5 years ago by shevek

  • Status changed from assigned to local_testing

Okay removed the background for 'no comments' entries. Increase the whiteness of all real comment boxes (actually using white still looks grey here).

Sorting not done yet but can be tested locally already.

Commit: https://gitorious.org/~thisismeonmounteverest/bewelcome/timeome-rox/commit/fe734a7dca63cacd196a9c5cca2afb73a2d104cc

comment:10 Changed 5 years ago by mahouni

local_testing on the mileston 1.5 branch:
https://gitorious.org/~mahouni/bewelcome/mahouni-rox/commits/ms15_develop_20130129

Don't forget the Database update for ticket #1892 and #1858.
Check: http://trac.bewelcome.org/wiki/DatabaseChanges

Last edited 5 years ago by mahouni (previous) (diff)

comment:11 Changed 5 years ago by shevek

Please also note that the cache breaker haven't yet been added. So you need either clear cache or force reload to see the CSS change.

comment:12 Changed 5 years ago by dima42

This looks good to me. (Not sure if you want to do the sorting on the same ticket; if so let me know and I'll review when you're done with that)

comment:13 Changed 5 years ago by jsfan

  • Status changed from local_testing to to_alpha

Looks good to me. Cleared for alpha.

comment:14 follow-up: Changed 5 years ago by crumbking

Ohh my good do you really want to leave these white boxes? It looks really bad ;-) What's the problem with the current design on www. It looks more lightweight (even the grey box is too much in my opinion)

Why do we need to show the nocommentyet info? What's the info value for the profile visitors?

comment:15 follow-up: Changed 5 years ago by crumbking

I would remove the nocommentyet infos. Exception: If I visit a profile of a member which I did not wrote a comment I would show the info straight on top of the list with the info: Hey, this member wrote the following comment about you. Reply him, too! ;-)

Alternative: Like CS a page with all open comments of a user....

Last edited 5 years ago by crumbking (previous) (diff)

comment:16 in reply to: ↑ 14 ; follow-up: Changed 5 years ago by shevek

Replying to crumbking:

Ohh my good do you really want to leave these white boxes? It looks really bad ;-)

You see white? I only see grey boxes for whatever reason.

What's the problem with the current design on www. It looks more lightweight (even the grey box is too much in my opinion)

For me it lacks structure. But I'm open for suggestions.

Why do we need to show the nocommentyet info? What's the info value for the profile visitors?

To keep things the same. If we sort the info into the timeline the display gets rather ragged otherwise.

comment:17 in reply to: ↑ 15 Changed 5 years ago by shevek

Exception: If I visit a profile of a member which I did not wrote a comment I would show the info straight on top of the list with the info: Hey, this member wrote the following comment about you. Reply him, too! ;-)

Alternative: Like CS a page with all open comments of a user....

Different tickets I'd say.

comment:18 follow-up: Changed 5 years ago by jsfan

I see an error

Notice: Undefined property: stdClass::$Username in /var/www/rox/build/members/templates/profile.subcolumn_right.php on line 213

which I believe wasn't there before. Looks like the username isn't passed properly.

comment:19 Changed 5 years ago by jsfan

  • Status changed from to_alpha to testing

comment:20 in reply to: ↑ 16 Changed 5 years ago by crumbking

Replying to shevek:

Replying to crumbking:

Ohh my good do you really want to leave these white boxes? It looks really bad ;-)

You see white? I only see grey boxes for whatever reason.

remove the div's and this css.
div.frame {

background: none repeat scroll 0 0 #FFFFFF;
padding: 5px;

}

What's the problem with the current design on www. It looks more lightweight (even the grey box is too much in my opinion)

For me it lacks structure. But I'm open for suggestions.

Well there are hr's between a group of comments. What else structure do you need?

Why do we need to show the nocommentyet info? What's the info value for the profile visitors?

To keep things the same. If we sort the info into the timeline the display gets rather ragged otherwise.

Okay but could we move for example in kiwiflave's comments my "CommentNoComment?" part on top of the list and add the comment button in the text section?. Because this would be a great reminder for every user while surfing on other profiles. See http://alpha.bewelcome.org/members/kiwiflave/comments

comment:21 follow-up: Changed 5 years ago by shevek

After seeing it on alpha I agree the white is too much. But I want to have a way to show the differences between the comment boxes. Left ones without a reply should look different from the other boxes.

The hrs aren't really visible here so they don't count as structure for me.

I'd be happy to move a comment left for the member visiting a profile with no response to the top of the list. Shouldn't be that problematic. Still, I'd say that's a different ticket.

Another open question is shall I check for sorting? Currently all unanswered comments end up at the end of the list.

comment:22 in reply to: ↑ 18 Changed 5 years ago by shevek

Replying to jsfan:

I see an error

Notice: Undefined property: stdClass::$Username in /var/www/rox/build/members/templates/profile.subcolumn_right.php on line 213

which I believe wasn't there before. Looks like the username isn't passed properly.

Seems that the changes to member.entity.php trigger that. I need to investigate this.

comment:24 Changed 5 years ago by jsfan

No more PHP notices. :-)

comment:25 in reply to: ↑ 21 Changed 5 years ago by crumbking

Replying to shevek:

After seeing it on alpha I agree the white is too much. But I want to have a way to show the differences between the comment boxes. Left ones without a reply should look different from the other boxes.

The hrs aren't really visible here so they don't count as structure for me.

Hey what kind of bad screen do you have? ;-) Anyway I will upload some drafts...

I'd be happy to move a comment left for the member visiting a profile with no response to the top of the list. Shouldn't be that problematic. Still, I'd say that's a different ticket.

I would say this would be the ideal solution for the ticket description: "I think it is needed to provide a way for the user to see all the comment he has written. This will increase the will of the member to put comments on other people."

Another open question is shall I check for sorting? Currently all unanswered comments end up at the end of the list.

Yes let's sort via time of the other commenter, too. So both comments from new to old and then mixed together ;-)

There is something wrong with the profile picture on alpha.
My guess it's a missing c for the avatar here:
https://gitorious.org/~thisismeonmounteverest/bewelcome/timeome-rox/blobs/fe734a7dca63cacd196a9c5cca2afb73a2d104cc/build/members/templates/comment_template.php#line102

see end of the page: http://alpha.bewelcome.org/members/beatnickgr/comments

Changed 5 years ago by crumbking

Changed 5 years ago by crumbking

Changed 5 years ago by crumbking

comment:26 Changed 5 years ago by shevek

Replying to crumbking:

The hrs aren't really visible here so they don't count as structure for me.

Hey what kind of bad screen do you have? ;-)

Dell U2713HM. :-P

Anyway I will upload some drafts...

Could you add one that shows how it would look like if there's no comment left yet?

I'd be happy to move a comment left for the member visiting a profile with no response to the top of the list. Shouldn't be that problematic. Still, I'd say that's a different ticket.

I would say this would be the ideal solution for the ticket description: "I think it is needed to provide a way for the user to see all the comment he has written. This will increase the will of the member to put comments on other people."

I always read that the other way round. But yes to get a reminder that I could write a comment would be good.

Another open question is shall I check for sorting? Currently all unanswered comments end up at the end of the list.

Yes let's sort via time of the other commenter, too. So both comments from new to old and then mixed together ;-)

I try to get sorting and the push implemented during the weekend if that fails (need to setup a new system at home) we should release without that and push sorting to a new ticket.

My guess it's a missing c for the avatar here:
https://gitorious.org/~thisismeonmounteverest/bewelcome/timeome-rox/blobs/fe734a7dca63cacd196a9c5cca2afb73a2d104cc/build/members/templates/comment_template.php#line102

Agreed: https://gitorious.org/bewelcome/rox/commit/368e47497674b8fae84b3f85a6230f086d686d97

comment:29 Changed 4 years ago by shevek

  • Status changed from testing to needs_work

Found a problem with the last commit. Removed the white for complete comments (just adding a frame around the whole comment section). Reset the color of the counter comment to original #eee.

Commit: https://gitorious.org/bewelcome/rox/commit/621cdc9c950bbedc486997c24a56943e701c3a10

comment:30 Changed 4 years ago by shevek

  • Status changed from needs_work to local_testing

Please test locally.

comment:31 Changed 4 years ago by crumbking

As a compromise I can live with the borders now ;-)

I have seen you added a comment button on the "others" profiles. But just thought it would even make more sense to add it in my own profile, too! Means if I'm henri and kermit wrote already to kermit: Below kermit's comment will be a counter comment: CommentNoComment? from henri to kermin with a "add comment"
Only visible by henri.

I hope you understand what I mean ;-)

You commits work btw.

comment:32 Changed 4 years ago by shevek

I didn't really add a new button. The 'Add comment' button was always shown when you didn't leave a comment for a member yet.

What I changed was that the button is part of the comment box now as the missing comment is pushed to the top.

After rereading your comment twice I think I got it :-) (see soon to be attached patch file)

Last edited 4 years ago by shevek (previous) (diff)

Changed 4 years ago by shevek

Add a 'Add Comment' button to unreplied comments (updated)

comment:33 Changed 4 years ago by jsfan

  • Status changed from local_testing to to_alpha

Not sure if your latest patch has been committed. Deploying regardless.

comment:34 Changed 4 years ago by jsfan

  • Status changed from to_alpha to testing

comment:35 Changed 4 years ago by shevek

I didn't commit that patch yet. But do that now, so that people can test locally.

Commit: https://gitorious.org/bewelcome/rox/commit/0813b4f202fbf98a3c9efd25ac0f1067db17c158

comment:36 Changed 4 years ago by mahouni

I tested that button for unreplied comments locally: works on the own comment page of the logged in member aswell as on a comment page of another members who has written a comment for the logged in member.

Code is ready for alpha (maybe an indent in lines 199-205 necessary?).
I'll leave the ticket with status testing, though the latest commit is not yet on alpha.

comment:37 Changed 4 years ago by jsfan

Deployed latest commit.

comment:38 Changed 4 years ago by shevek

I'm wondering if we should show the user name in the add comment cutton. Like 'Leave a comment for jsfan'? Would make things more personal.

comment:39 Changed 4 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

Totalf tested on alpha accoring to this thread: http://alpha.bewelcome.org/forums/s5348-1_5_release_testing

Closing as fixed.

comment:40 Changed 4 years ago by crumbking

  • Resolution fixed deleted
  • Status changed from closed to reopened

Öhm there is an issue that I visit another profile:

http://alpha.bewelcome.org/members/jsfan/comments

No comment given yet
from sitatara to jsfan with a add comment button which only sitatara should see... (not me)

comment:41 Changed 4 years ago by shevek

I don't see that on jsfan's profile but on sitatara's profile. So it's probably connected to the fact that I didn't leave a comment for her. I dig into that.

comment:43 Changed 4 years ago by jsfan

  • Status changed from reopened to to_alpha

comment:44 Changed 4 years ago by jsfan

  • Status changed from to_alpha to testing

Fix now on alpha.

comment:45 Changed 4 years ago by shevek

Hm, fix didn't work. Checking for $this->myself obviously doesn't tell you you're browsing your own profile. Need to dig deeper.

comment:46 Changed 4 years ago by shevek

Seems to have been a spurious '!' in the code. Please push to alpha: https://gitorious.org/bewelcome/rox/commit/4c5b6ff37a854876e2fe3fff056cb11327339e37

comment:47 Changed 4 years ago by shevek

comment:48 Changed 4 years ago by jsfan

Deployed. Looks good to me.

Close if confirmed.

comment:49 Changed 4 years ago by shevek

Crumbking found another problem but submitted a fix that planetcruiser just committed.

comment:50 Changed 4 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

Looks good to me. Closing as fixed.

comment:51 Changed 4 years ago by crumbking

  • Resolution fixed deleted
  • Status changed from closed to reopened

Well don't know what have been tested on alpha:

But I see some errors:

Notice: Trying to get property of non-object in /var/rox/deployment/alpha.bewelcome.org-7806fb1/build/members/templates/comment_template.php on line 121

http://alpha.bewelcome.org/members/daydreamer1969/comments

Last edited 4 years ago by crumbking (previous) (diff)

comment:52 Changed 4 years ago by midsch

I can confirm this: When I'm logged in, daydreamer1969's comment page looks good, by when I'm logged out and access a comment page from a public profile the error is visible for unanswered comments from this user:

Notice: Trying to get property of non-object in /var/rox/deployment/alpha.bewelcome.org-7806fb1/build/members/templates/comment_template.php on line 121

another example: http://alpha.bewelcome.org/members/robino/comments

comment:53 Changed 4 years ago by shevek

The problem is that it tries to access the id of the logged in member which fails as there is none. The check if you want to add a comment at the start of the comment_template.php file is fine as that doesn't check for the id.

Can't fix this myself, but if someone adds a isset($this->loggedInMember) to the condition or around the condition on line 121 that would fix it.

comment:54 Changed 4 years ago by crumbking

  • Status changed from reopened to to_alpha

comment:55 Changed 4 years ago by crumbking

on the commentNocomment ones we do not show the grey frame. Any reason for that? I would remove the check in the beginning.

comment:56 Changed 4 years ago by shevek

That's intentional. I want the mutual comments look different from the unilateral.

comment:57 Changed 4 years ago by shevek

  • Status changed from to_alpha to testing

Fixed worked for the described problem. checked some things around that as well. still working. Closing as fixed again.

comment:58 Changed 4 years ago by shevek

  • Resolution set to fixed
  • Status changed from testing to closed

comment:59 Changed 4 years ago by crumbking

  • Component changed from BW General to BW Profile
Note: See TracTickets for help on using tickets.