Opened 10 years ago

Closed 5 years ago

#272 closed improve feature (wontfix)

Title for BW pages

Reported by: jeanyves Owned by: guaka
Priority: major Milestone: unassigned
Component: BW Layout Keywords: title, easy
Cc: lemon-head, steinwinde

Description

Currently all BW page in PT mode have the same title : BeWelcome

this is to improve and a core feature is to be designed

for example :

  • forum thread page should have teh title of the thread
  • cities pages should have "Bewelcome members in XXXX" as title

etc etc ...

This is quite important for pages visibility, so I put this in critical

Change History (21)

comment:1 Changed 10 years ago by micha

  • Milestone changed from unassigned to 0.1.2 - more improvements & bugfixing

It should be possible to solve this in the next release.

comment:2 Changed 10 years ago by lemon-head

Please have a look at 'text/en/page.php', and 'text/de/page.php'.

There the variable 'PVars::getObj('page')->title' is set, which is later read in 'templates/page.php' to determine the page title.

The appropriate place to set a title could be the View classes..

comment:3 Changed 10 years ago by lemon-head

  • Component changed from unknown to BW General
  • follow_up changed from none to review code
  • Owner set to lemon-head
  • Status changed from new to assigned

See [3915] and [3916]

We need to

  • decide if this is a good way to create the titles.
  • decide if the chosen titles are ok.
  • when we're happy with it, do the same for other applications.

comment:4 follow-up: Changed 10 years ago by lemon-head

Not to forget:

  • use MOD_words for the page titles!!

comment:6 in reply to: ↑ 4 Changed 10 years ago by jeanyves

  • Cc lemon-head steinwinde added

Replying to lemon-head:

Not to forget:

  • use MOD_words for the page titles!!

Good I think this is the idea in general.
One point, how to change this title elsewhere than in Page*.php something ? Could it be possible to have a methot for this like Page->SetTitle?($newTitle) ?

It should also be compatible with the new PT version.

And in the same idea, I would like to have (just like in old BW) a :

Page->SetMetaKey?() : to set the meta key word to something tunable (with a default value)

Page->SetMetaRobot?() : to set the meta key for robot to something tunable (with a default value)

comment:7 Changed 10 years ago by lemon-head

  • freq_reported set to 1
  • Keywords easy added
  • show_on_bw set to 0

Now that we know how it works, it should be easy to introduce additional page titles.

PVars::getObj('page')->title = "Collecting stamps is sexier than traveling - BeWelcome Groups";

(you can do that in the view classes)

comment:8 Changed 10 years ago by lemon-head

  • Owner lemon-head deleted
  • Status changed from assigned to new

Anyone can do this - so I make the ticket open for everyone.

Btw, with the new #436 architecture, a page title is set by overwriting the method inherited from RoxPageView::getPageTitle()

comment:9 Changed 9 years ago by guaka

  • Owner set to guaka

comment:10 Changed 9 years ago by guaka

I tried getPageTitle thing, but it didn't work. I'll try again later.

comment:11 Changed 9 years ago by jeanyves

Andreas and Felix probably have ideas about this.

When you will have find the solution, I will be very happy to have a a thread as title of the page for each forum page thread.

JeanYves?

comment:12 Changed 9 years ago by lemon-head

@guaka:
If you really want to find out, I recommend the following:

  1. make a fulltext search for "$Page->title" (or "$page->title), and "PVars::getObj('page')->title". This should be quite revealing for those applications that work with the PVars::getObj('page') global.
  1. Some newer applications all define their pages as subclasses of "PageWithRoxLayout" (formerly known as "RoxPageView"). PageWithRoxLayout has a method called getPageTitle(), which by default returns "BeWelcome". To define a different page title, you have to override this method in the specific subclass.

You can see this happen in the definition of PersonalStartpage::getPageTitle(), which returns something like "Welcome, Username".

comment:13 Changed 9 years ago by philipp

  • Milestone changed from 0.1.4 - improving userinterface for members and volunteers and start work on big 0.2 tasks to 0.5.2-short cleanup and framework

comment:14 Changed 9 years ago by guaka

for searchmembers: r4638

comment:15 Changed 8 years ago by crumbking

  • Priority changed from critical to major

I just checked some apps on production and it seems some of them have a page title and some not.no title:

  • groups
  • edit profile (shows just "users" profile on BeWelcome)
  • my messages (shows just "users" profile on BeWelcome)
  • my preferences (shows just "users" profile on BeWelcome)
  • my profile visitors (shows just "users" profile on BeWelcome)
  • comments
  • trips
  • blogs
  • FAQ
  • feedback
  • my gallery

all should be translatable

comment:16 Changed 8 years ago by micha

group titles added in trunk

comment:17 Changed 8 years ago by crumbking

  • Milestone changed from 0.5.2-short cleanup and framework to Future

comment:18 Changed 5 years ago by TimLoal

  • Component changed from BW General to BW Layout

comment:19 Changed 5 years ago by TimLoal

  • Milestone changed from Future to unassigned

comment:20 Changed 5 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:21 Changed 5 years ago by planetcruiser

  • Milestone set to unassigned
  • Resolution set to wontfix
  • Status changed from new to closed

won't be fixed for rox. a rewrite will make sure page titles make more sense

Note: See TracTickets for help on using tickets.