Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#28 closed new feature (fixed)

searchmembers improvements

Reported by: philipp Owned by: jaliste
Priority: major Milestone: 0.1-outreach-release
Component: FrameWork Keywords: geo
Cc: philipp, jose.aliste@…

Description (last modified by jaliste)

  • remove prefilled content from "search map by text" form field
  • perform search after user hits "enter"
  • allow search based on username, age, words without restriction by map.

Change History (10)

comment:1 Changed 10 years ago by philipp

  • Owner yj deleted

comment:2 Changed 10 years ago by jaliste

  • Owner set to jaliste
  • Status changed from new to assigned
  • For performing search when user hits enter we should handle it with a keyUp event?


  • I don't know what you mean by prefilled content.
  • And by allow search wihout restriction by map you mean to being able to disable the map? because this doesn't work in test, or another way?

comment:3 Changed 10 years ago by philipp

  • no idea about keyUP if other thing could be better
  • the prefilled content has already been removed by felix
  • map restriction:

right now you have to either put in a location (and then get all matches in the surrounding) or chose an area on the map and get all results from this area.
Though it would be neccessary to be able to get the matches from all entries. this could be achieved either by:

  • zooming the map so that everything fits in there and do a normal "search by map" or
  • don't call map restrcition at all but do the search only on the database (haven't looked into the code but the second seems to be preferrable.

-displing map forked until a couple of days - so maybe you can find the bug, would be cool to have it back

comment:4 Changed 10 years ago by jaliste

So I looked up the HTML code and there are three different forms!!! So,
we have two options... Either I add some event listener to the first form(which has all the input fields) to listen for the enter key or I mix all the forms into only one,
this implies heavier modifications of the javascript, but also would make easy to have a failover page(there is three submits buttons in this page... only search by map should be a submit, the other should be buttons with onclick functions!)
in case you have javascript disabled(in this moment this doesn't work... should file another bug for that, but after)

what do you think?

comment:5 Changed 10 years ago by jaliste

  • Description modified (diff)

So, first enhancement is already done by Felix.
For second enhancement(Enter key) I added #42. For third enhancement I added #43.

Depends: #42, #43.

comment:6 Changed 10 years ago by jaliste

  • Cc jaliste added

testing ccing.

comment:7 Changed 10 years ago by jaliste

Testing ccing

comment:8 Changed 10 years ago by jaliste

  • Cc jose.aliste@… added; jaliste removed

comment:9 Changed 10 years ago by jaliste

testing ccing

comment:10 Changed 10 years ago by philipp

  • Resolution set to fixed
  • Status changed from assigned to closed

think all this has been fixed in the recent revisions

Note: See TracTickets for help on using tickets.