Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#341 closed bug (fixed)

Age display is wrong

Reported by: ocal5 Owned by: matrixpoint
Priority: major Milestone: 0.1.2.1
Component: BW Profile Keywords: age, date
Cc:

Description

After an quite heavy week-end... I hear that I have older of one more year :-/ Thanks, but not so quickly please !

I'm not able to test it easily : No way to change birthday on profile, and I don't know tools to do that on admin@…

only clue is : it says that I'm 22, but it will be on 26th of Jan, and we're only 21st. My date is written this way : "1986-01-26"

Somebody else from January ?

Change History (13)

comment:1 Changed 11 years ago by micha

  • Milestone changed from unassigned to 0.1.3 - more improvements & bugfixing
  • Owner set to micha
  • Priority changed from minor to major
  • Status changed from new to assigned

I think this is rather important. We can't just tell lies about our members ;)

comment:2 Changed 11 years ago by matrixpoint

  • follow_up changed from none to test

Fixed in r3813.

comment:3 Changed 11 years ago by matrixpoint

  • follow_up changed from test to none

Reverted in r3813. Already fixed?

comment:4 Changed 11 years ago by matrixpoint

  • follow_up changed from none to test

Fixed on r3829. Old version for searchmembers didn't take into account leap years, so would increment the age a few days early.

comment:5 Changed 11 years ago by matrixpoint

I forgot, the fage_value() function is in two places now. Fixed in FunctionTools?.php (BW) in r3831.

The two files to move to alpha are: build/searchmembers/searchmembers.model.php and htdocs/bw/lib/FunctionTools.php.

comment:6 Changed 11 years ago by matrixpoint

  • follow_up changed from test to test on alpha

Moved to alpha in r3843 and r3847.

For testers: the problem was that the age incremented a few days before someone's birthday because the extra days in leap years were not counted. So, to really test this fix, you would have to find someone with a birthday a few days from now that you know. This might be so difficult to find that we can go ahead and release it as long as the correct age appears for everyone you check on the searchmembers page and the profile page.

comment:7 Changed 11 years ago by matrixpoint

I ran into some bad data in the member table BirthDate? field (zero value) on the test server, so I added a test for that that returns a zero age value in r3863. Moved to alpha in r3864.

comment:8 Changed 11 years ago by matrixpoint

  • Milestone changed from 0.1.3 - more improvements & bugfixing to 0.1.2.1 release with MOD_words + MOD_layoutbits + TinyMCE update

comment:9 Changed 11 years ago by micha

  • Owner changed from micha to matrixpoint
  • Status changed from assigned to new

I have the feeling that there is another problem to solve. At least we have to check something: I remember that on signup I entered my correct birthday. But in fact, when I look it up on "edit my profile", then I can see that my year of birth has changed by 1 year: Even if in real life I'm 24, I am displayed in BW as 25 years of age.

At least this (see above) is not fixed on alpha. Couldn't test on test.bw.org yet.

comment:10 Changed 11 years ago by matrixpoint

Do you also get the same error on the searchmembers result (this is controlled by a BW-Rox function fage_value rather than the BW function in FunctionTools?.php fage_value? Just wondering. If you send me your birthday I can check it on my localhost.

comment:11 Changed 11 years ago by micha

  • follow_up changed from test on alpha to release

I figured out that this error has nothing to do with your fix or the BW or Rox functions. Somehow my data must have gotten scrumbled in the beginnings of BW. Your fix is fine I think. I just signed up with a new test-account on alpha and everything looks good.

I think, we just have to make sure that there is not any more scrumbled age-data around in our DB (Don't know how to check this)

comment:12 Changed 11 years ago by micha

  • Resolution set to fixed
  • Status changed from new to closed

comment:13 Changed 11 years ago by matrixpoint

  • follow_up changed from release to none

Released to production in r3882

Note: See TracTickets for help on using tickets.