Opened 11 years ago

Closed 11 years ago

#347 closed improve feature (fixed)

A validation button for image text label change

Reported by: ocal5 Owned by: micha
Priority: minor Milestone: 0.1.4
Component: BW General Keywords: image rename gallery
Cc: jeanyves

Description

Now there is a wonderfull gallery, who is working nicely.

In that one, we can change text name of pictures, it works by pressing enter, but there is not button to click on and do the same.

http://www.bewelcome.org/gallery/show/image/XXX

Report is thanks BW:kiwiflave

tested on test, alpha & production, using Opera 9.5(b)

Thanks

Change History (14)

comment:1 Changed 11 years ago by micha

  • Milestone changed from unassigned to 0.1.3 - more improvements & bugfixing
  • Owner set to micha
  • Status changed from new to assigned

comment:2 Changed 11 years ago by micha

  • follow_up changed from none to test
  • freq_reported set to 1
  • show_on_bw set to 0

Fix uploaded. Please test on test.bewelcome.org/gallery

comment:3 Changed 11 years ago by micha

  • follow_up changed from test to move to alpha

Please move to alpha: revisions 3984,3985,3986,3987

comment:4 Changed 11 years ago by matrixpoint

  • Cc jeanyves added

I am reluctant to move this to alpha because dbupdates.php needs to go with it (r3985), and there are more than 25 other DB updates besides the new gallery_comments table (comparing the trunk version to the alpha version). It might be better if jeanyves checks this first.

comment:5 Changed 11 years ago by jeanyves

You are right John, this need a bit of coordination.

In general I apply the change manually on the live database and never by dbupdate.

I can take care of it, this afternoon (french afternoon, -btw you are very early today, I hope your back let you sleep a bit-)

I will : look at the db update prepare the db commit (I hope this compatible with previous version, I will check) apply it and commit the changes

comment:6 Changed 11 years ago by matrixpoint

Moved to alpha in r4100.

comment:7 Changed 11 years ago by matrixpoint

  • follow_up changed from move to alpha to test on alpha

comment:8 Changed 11 years ago by matrixpoint

  • follow_up changed from test on alpha to test

I tested on alpha and everything seemed to work, but then I thought to check on localhost whether the comments are deleted when the picture is deleted. I don't think so. So this should be fixed, or else orphaned comments will stay in the DB.

I did set the words.

Reverted in r4104.

comment:9 Changed 11 years ago by matrixpoint

Note from jeanyves from dev discussion:

I have look to the DB. In fact it is very compatible with old TB (funny to speak about old TB ;-) ) initial gallery. So I have created the new table introduced by Micha and added the description field to item.

It is now ready for receiving the new update Micha did. Only thing to consider, is that I don't really know waht will happen if some gallery data are made from new Alpha feature and if someone after change them in the online production.

What I suggess is : 1) a move to alpha and quick test 2) if not ok revert 3) if ok, we immediately move it to production

if we wait between 1 an 2 too much, the risk is to have orphan gallery_comments record if someone update the gallery item (and I don't know even if this is possible) with the current live gallery tools. I think this is a low risk

Does someone understand what I mean ? (If so, lets move up ;-) )

comment:10 Changed 11 years ago by matrixpoint

One more note: there may be some orphaned comments from my test in the gallery_comments table.

Incidentally, the picture I uploaded on alpha seemed to delete itself. I think this was happening before, and we never really found the reason. I think it only happens on alpha.

comment:11 Changed 11 years ago by matrixpoint

In r4109, I added a function in gallery.model.php to delete all comments associated with a picture when it is deleted. Please test this on your localhost.

I notice that there is a function deleteAll for deleting the entire gallery_items table contents. I'm not sure why this is there, but it should also delete all comments, I would think. The function I made could be adapted for this. Maybe Micha could decide about this.

comment:12 Changed 11 years ago by micha

I just uploaded further changes on gallery.model.php (Just added logs). I left the deleteAll-function as it was because I don't think that it is of any use for now. I wouldn't touch it.

I also improved the info about the deletion

Thanks for your help guys!

rev. 4128 $ 4129. Please test and hopefully move to alpha soon.

comment:13 Changed 11 years ago by matrixpoint

  • follow_up changed from test to test on alpha

Moved to alpha in r4131

comment:14 Changed 11 years ago by matrixpoint

  • follow_up changed from test on alpha to none
  • Resolution set to fixed
  • Status changed from assigned to closed

Moved to production in r4132.

Note: See TracTickets for help on using tickets.