Ticket #363 (closed improve feature: fixed)

Opened 4 years ago

Last modified 4 years ago

new system for language switching

Reported by: lemon-head Owned by:
Priority: major Milestone: 0.1.2.1
Component: BW General Keywords:
Cc:

Description

Currently the language switch rox/in/lang, as well as the rox/tr_mode/* use the PRequest::back() to get back to the page you were viewing.
This is not very reliable and can cause serious problems, as explained in #313, #336, #350, and in one email I wrote.

New system:
Instead of 'rox/in/lang', we now send a request 'rox/in/lang/original/page'. This way, we don't need PRequest::back().

Example:
on searchmembers/index, the request to switch to finnish will be 'rox/in/fi/searchmembers/index'. Then 'header("Location: searchmembers/index")' is called to make the redirect.

Change History

comment:1 Changed 4 years ago by lemon-head

should be fixed with [3823] - new language switcher

comment:2 Changed 4 years ago by lemon-head

  • follow_up changed from none to test

comment:3 Changed 4 years ago by matrixpoint

  • follow_up changed from test to test on alpha

Moved to alpha in r3855.

comment:4 Changed 4 years ago by matrixpoint

Works on alpha.

comment:5 Changed 4 years ago by philipp

  • follow_up changed from test on alpha to release
  • Status changed from new to closed
  • Resolution set to fixed

comment:6 Changed 4 years ago by matrixpoint

  • follow_up changed from release to none

Released in r3937.

Note: See TracTickets for help on using tickets.