Opened 11 years ago

Closed 11 years ago

Last modified 6 years ago

#367 closed bug (fixed)

login form: action attribute should not be empty (better for pw managers)

Reported by: lemon-head Owned by: lemon-head
Priority: minor Milestone: Legacy Resolved
Component: BW Profile Keywords: login
Cc: micha, jeanyves, matrixpoint

Description

Some pw managers don't like empty action attributes in the login form. This can be solved easily.

Change History (10)

comment:1 Changed 11 years ago by lemon-head

  • follow_up changed from none to test
  • Owner set to lemon-head
  • Priority changed from major to minor
  • Status changed from new to assigned

Should be solved with [3878].

This changeset can go to alpha and production independent from other stuff.

comment:2 Changed 11 years ago by micha

  • follow_up changed from test to move to alpha
  • freq_reported set to 1
  • show_on_bw set to 0

ok, looks fine. let's move this to alpha: 3878

comment:3 Changed 11 years ago by matrixpoint

Please double check this. It looks to me like r3878 was replaced by r3953 and then r3957 from ticket #389.

comment:4 Changed 11 years ago by feuerdaemon

I checked it on test with FF and MS IE. It seems ok. So let's move it to alpha.

comment:5 Changed 11 years ago by philipp

  • Cc micha jeanyves matrixpoint added

comment:6 Changed 11 years ago by matrixpoint

But the change shown in r3878

echo implode('/', $request); -> echo PVars::getObj('env')->baseuri . implode('/', $request);

is no longer in the file loginform.php on trunk. This change was overwritten by a latter commit. Actually, it was commented out:

action is current request echo PVars::getObj('env')->baseuri . implode('/', $request); better: use flexible redirect url, but don't pass it as the "action" (could be an old-bw address, for instance)

So, I don't see how it could be tested on the test server, if this is really the desired change as documented above (r3878). If the current version of loginform.php, with the new code is actually the correct, working version, please confirm this.

comment:7 Changed 11 years ago by feuerdaemon

I've had just tested the value of the form action.

On test the action value comes via a static print command from php. I think this change should go to production, that the pwd-managers are happy. It's right - that does not solve the problem with ticket r3878 but this ticket will.

comment:8 Changed 11 years ago by jeanyves

I don't understand what to commit to alpha

comment:9 Changed 11 years ago by feuerdaemon

  • follow_up changed from move to alpha to none
  • Resolution set to fixed
  • Status changed from assigned to closed

Hm. Somehow the chances are in production

root/trunk/templates/apps/user/loginform.php

36 <input type="text" id="login-u" name="u" <?php
43 <input type="password" id="login-p" name="p" />

So ticket can be closed.

comment:10 Changed 6 years ago by TimLoal

  • Component changed from BW General to BW Profile
  • Milestone changed from unassigned to Legacy Resolved
Note: See TracTickets for help on using tickets.