Opened 11 years ago

Closed 11 years ago

#380 closed bug (fixed)

The link to adminwords for a language use wron language parameter

Reported by: jeanyves Owned by: lemon-head
Priority: critical Milestone: 0.1.2.1
Component: BW General Keywords: translation adminword
Cc: lemon-head, jean-yves, micha

Description

I am here speaking about the new links introduced by Andrea (the "FR" or "DE" which is displayed after each word if the user is in "edit" mode (which is a cool idea, but this is not the point)

currently the url use (for french for exemple): http://alpha.bewelcome.org/bw/admin/adminwords.php?lang=fr&code=NbMembersOnline it should be http://alpha.bewelcome.org/bw/admin/adminwords.php?IdLanguage=1&code=NbMembersOnline, because this is what adminword is expecting

of course it could be possible to change adminword too, but I prefer not to touch it (since adminwords is teh tool I implemented for HC and reuse for BW with lot of additional features but without deciding -what should be make some day- to rewrite some old part of the code, I really prefer not change it).

@Andreas could you change the initial url ? I guess this will be more safe.

Nota : if we don't do this for now, it links to adminwords but with and empty content, so the risk is translator to redo again an again the same translation

Change History (7)

comment:1 Changed 11 years ago by lemon-head

  • Owner set to lemon-head
  • Status changed from new to assigned

It's more tricky than that - the $_GETIdLanguage? is never used in adminwords.php.

[3902] is a nice little workaround.

comment:2 Changed 11 years ago by lemon-head

  • Cc jean-yves added
  • Component changed from unknown to BW General
  • follow_up changed from none to move to alpha
  • Milestone changed from unassigned to 0.1.2.1 release with MOD_words + MOD_layoutbits + TinyMCE update

looks ok on test.bw

Please move the following to alpha:

  • the full bw/admin/adminwords_edit.php
  • the changes in the method _trLinkTitle() in words.lib.php
  • leave the rest of words.lib.php as it is!!!

comment:3 Changed 11 years ago by lemon-head

[3903] - workaround improved.

The 'move to alpha' procedure is still the same as above, but with the new version of 'adminwords_edit.php' !

comment:4 Changed 11 years ago by lemon-head

[3906] - sanitizing in MOD_words disabled. Now we can move the entire words.lib.php to alpha.

comment:5 Changed 11 years ago by lemon-head

  • Cc micha added

comment:6 Changed 11 years ago by matrixpoint

  • follow_up changed from move to alpha to test on alpha

Moved to alpha in r3911.

comment:7 Changed 11 years ago by matrixpoint

  • follow_up changed from test on alpha to none
  • Resolution set to fixed
  • Status changed from assigned to closed

Released in r3925.

Note: See TracTickets for help on using tickets.