Opened 11 years ago
Closed 10 years ago
#382 closed improve feature (fixed)
URLs for Forum threads
Reported by: | lemon-head | Owned by: | lemon-head |
---|---|---|---|
Priority: | minor | Milestone: | 0.5.2 |
Component: | BW Forum | Keywords: | nice urls |
Cc: |
Description
Currently the URLs for forum subjects have problems:
- whitespaces are turned into %20, which looks ugly.
- a title 'please/reply' will result in an adress that is understood as a request saying you want to reply.
I think it's nicer to turn everything into url-friendly characters like '_' or '-' etc.
Change History (6)
comment:1 follow-up: ↓ 2 Changed 11 years ago by lemon-head
- follow_up changed from none to review code
- Owner set to lemon-head
- Status changed from new to assigned
comment:2 in reply to: ↑ 1 Changed 11 years ago by micha
- freq_reported set to 1
- show_on_bw set to 0
Replying to lemon-head:
[3912] - replaced problematic characters with '-'. We might still change some things later. Is '_' better? And maybe the function does not belong in class ForumsView? ?
Now that you changed this behaviour anyway, could you try to get rid of a bug aswell? If you create a topic and start the title of the thread with ", the title won't be displayed in the URL. For an example see: http://test.bewelcome.org/forums/s29-
Any idea, why that is? Can you fix it?
comment:3 Changed 11 years ago by micha
I like your change by the way. And I don't care if it's a '-' or a '_' or whatever. Like this it's just fine. We just shouldn't change it too often, otherwise we get problems with static links on other pages/sites.
comment:4 Changed 11 years ago by lemon-head
No, we don't get such problems - everything that happens after the first '-' symbol is just decoration.
For instance, look where the following link takes you :)
comment:5 Changed 11 years ago by philipp
- Milestone changed from 0.1.4 - improving userinterface for members and volunteers and start work on big 0.2 tasks to 0.5.2-short cleanup and framework
please finish this one!
comment:6 Changed 10 years ago by feuerdaemon
- Resolution set to fixed
- Status changed from assigned to closed
JY solved this.
[3912] - replaced problematic characters with '-'. We might still change some things later. Is '_' better? And maybe the function does not belong in class ForumsView? ?