Ticket #416 (closed unknown: wontfix)

Opened 4 years ago

Last modified 3 years ago

signup strange problem

Reported by: jeanyves Owned by:
Priority: critical Milestone: unassigned
Component: unknown Keywords: signup
Cc: micha

Description

I committed a fix to avoid the click on the I accept terms to automatically create a fake submit. COudl some one dig a bit more in the problem (the result of my fix is that we can now tick the I accept terms box, but it create a line break).

I think this was another cause of many duplicated profile (I move it online, I think my fix is best than the current problems of duplicated we have, but a more clean fix is needed)

The file to look at is layout/signup.php (line 256 and after, the terms managment with the check box)

Change History

comment:1 Changed 4 years ago by micha

Mmmh, looked it over. Doesn't look as if your last commit was any fix at all. By the way: It's definitely wrong to just write incorrect HTML by a javascript function. The check should be looked over again. Maybe take the new signup from Felix or old TB registerform as an example.

comment:2 Changed 4 years ago by guaka

  • Keywords signup added; Signup removed
  • Summary changed from signup starnage problem to signup strange problem

starnage->strange?

comment:3 Changed 3 years ago by philipp

  • follow_up changed from review code to none
  • Status changed from new to closed
  • Resolution set to wontfix

will be taken care of by #475, closing this one

Note: See TracTickets for help on using tickets.