Opened 10 years ago

Closed 5 years ago

#460 closed improve feature (wontfix)

Refactoring of forum application

Reported by: lemon-head Owned by: lemon-head
Priority: major Milestone: unassigned
Component: BW Forum Keywords:
Cc:

Description

I want to do some improvements on the forum application

Code gardening.

  • replace tabs by spaces, and fix indentation
  • comments using /..*/

Structural Refactoring

This can be a first step towards the more complex #436 RoxPageView scheme, but it doesn't have to be.

The advantages:

  • Cleaner code (hopefully)
  • Fewer lines wasted for redundant ob_start(), ob_end(), ob_get_contents(). However, this is not as important in the forums application as it is in other apps.
  • The application gets independent from the global PVars::getObj('page') object.
  • Easier transition to #436 RoxPageView scheme.

Change History (6)

comment:1 Changed 10 years ago by lemon-head

  • Component changed from unknown to BW Forum
  • Owner set to lemon-head
  • Status changed from new to assigned

[4339] - does it.

comment:2 Changed 10 years ago by lemon-head

  • follow_up changed from none to review code

comment:3 Changed 10 years ago by jeanyves

please, I am really on forum, this make the merging a bit more difficult, can you wait a bit ?

except this :
space instead of tabs, I am ok
/* */ to replace ? If it is the rule I don't like it
they are cases where /* */ are very usefeull to make a block inactive for example

and other case where a is very good to make a "title comment" before block or an additional comment in the end of a line, if you only use /* */, when you want to make inactive a big bloc you have to deal with all internal /* */, with you dont have this problem.

May be I misunderstood your intention ?

comment:4 Changed 9 years ago by public

There is a error message in the footer of the forum in alpha:
Notice: Undefined variable: versionInfo in /home/bwrox/alpha.bewelcome.org/templates/apps/rox/footer.php on line 82

not sure if this is related to this ticket.
crumbking

comment:5 Changed 5 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:6 Changed 5 years ago by shevek

  • Milestone set to unassigned
  • Resolution set to wontfix
  • Status changed from assigned to closed

Closing as forum is likely to use a new software anyway already.

Note: See TracTickets for help on using tickets.