Opened 11 years ago

Closed 10 years ago

#467 closed improve feature (fixed)

static maps - on profile page and elsewhere

Reported by: philipp Owned by: globetrotter_tt
Priority: minor Milestone: 0.5.2-long
Component: BW Profile Keywords:
Cc: philipp, midsch, globetrotter_tt

Description

static google maps are now available.

  • could be used to reduce load
  • could be used when javascript is disabled
  • a dynamic map could be loaded upon click
  • they can be used wherever an image can be used
  • it should be easy to cache them
  • they are currently limited to 50 markers, standard marker icon in 3 colors with one character

Attachments (1)

profile.png (190.1 KB) - added by feuerdaemon 11 years ago.
Unreadable Profile infos

Download all attachments as: .zip

Change History (18)

comment:1 Changed 11 years ago by philipp

I created a proof of principle on the profile page and main page - please test, comment and improve if you like.

Changed 11 years ago by feuerdaemon

Unreadable Profile infos

comment:2 Changed 11 years ago by feuerdaemon

The profile infos are pushed under the profile picture on FF 2.0.0.12 with Kubuntu. See uploaded picture.

comment:3 Changed 11 years ago by philipp

fixed the problem that the profile info is pushed under the picture - this now only happens when the window is too narrow, so still not perfect.

comment:4 Changed 11 years ago by micha

I think the maps should be rectangular and they should go with a border+title. else it looks really bad. Could you try to generate the maps based on the "terrain" maps by google?

comment:5 Changed 11 years ago by philipp

  • border: sure
  • title: what kind of title? I think it is pretty obvious what it shows, no?
  • rectagular: I agree, it would look much better, but you would hardly see anything if you place it in the header, though one might think of placing it into the main content on the right - well, maybe matthias has some nice ideas here (however it would be nice to fill the teaser with something useful)
  • terrain: no unfortunately not, currently static maps only provide normal and mobile (less information, bigger lables) map types.

comment:6 follow-up: Changed 11 years ago by midsch

  • title: what kind of title? I think it is pretty obvious what it shows, no?

-> not if you're blind, block images, what ever. _ALWAYS_ use titles for proper HTML.

comment:7 in reply to: ↑ 6 Changed 11 years ago by philipp

Replying to midsch:

  • title: what kind of title? I think it is pretty obvious what it shows, no?

-> not if you're blind, block images, what ever. _ALWAYS_ use titles for proper HTML.

you are probably talking about alternate text for images? yes this should definitely be added! Sorry I thought about some real "title, or caption" on top or below the map.

comment:8 Changed 10 years ago by globetrotter_tt

  • Owner set to globetrotter_tt
  • Status changed from new to assigned

comment:9 Changed 10 years ago by globetrotter_tt

I did some mofifcation with r5298:

  • added a title/caption above the map. It shows the location breadcrumb navi. see also #557
  • the <img> has an alternative text now ;)
  • the map is smaller, "more rectangular" and has a border

comment:10 Changed 10 years ago by feuerdaemon

  • follow_up changed from test to move to alpha

works fine on test. tested with Kubuntuand FF 3.0

comment:11 Changed 10 years ago by micha

  • Cc midsch globetrotter_tt added
  • follow_up changed from move to alpha to test on alpha
  • Milestone changed from unassigned to 0.5.2-long

moved to alpha in r5944. Please test.

comment:12 Changed 10 years ago by micha

  • Component changed from unknown to BW Profile
  • Type changed from unknown to improve feature

ok, on my local install of the production code I get an error, saying "Warning: mysql_fetch_object(): supplied argument is not a valid MySQL result resource in C:\Websites\bw-production\htdocs\bw\member.php on line 115"

As alpha seems to work, I guess that means other files have to be moved than in r5298. Please tell me, which files (or better revisions) have to be moved to production

comment:13 Changed 10 years ago by micha

  • Cc philipp added

comment:14 Changed 10 years ago by globetrotter_tt

On alpha i get for every profile except my own: Fatal error: Class 'LinkSinglePictureLinkpathWidget?' not found in /home/bwrox/alpha.bewelcome.org/htdocs/bw/member.php on line 85.

comment:15 Changed 10 years ago by globetrotter_tt

getting rid of the error with disabling the linkpath code from philipp in r5968. What i also noticed is that the footer is missing on old /bw pages. Seems that the rox/templates folder is missing on alpha

comment:16 Changed 10 years ago by micha

  • follow_up changed from test on alpha to release

Please move this to production!

comment:17 Changed 10 years ago by micha

  • follow_up changed from release to none
  • Resolution set to fixed
  • Status changed from assigned to closed

Ok, works on production BUT does still now work for other pages like comments, editmyprofile, contact etc. But maybe we really should wait with this till we have the rox-version working!

Note: See TracTickets for help on using tickets.