Opened 11 years ago

Closed 10 years ago

#475 closed improve feature (fixed)

Create a rox signup (instead of old bw/signup.php)

Reported by: globetrotter_tt Owned by: micha
Priority: critical Milestone: 0.5.2-long
Component: BW General Keywords: signup, register, hot
Cc: micha, philipp, globetrotter_tt

Description

Felix (steinwinde) started to implement the signup page in rox already 5 month ago. Time to continue the work

related tickets: #84, #105, #202, #264, #268, #315, #381, #416

Attachments (1)

signup_pw_validation.jpg (8.8 KB) - added by midsch 10 years ago.
Screenshot with confusing form fields

Download all attachments as: .zip

Change History (63)

comment:1 Changed 11 years ago by globetrotter_tt

The rox signup is available at http://test.bewelcome.org/signup/register.

It needs still a lot of improvements:

  • define the location selector interface #315
  • handling of invalid user input and description of fiels (i like it the way the do it on digg.com : http://digg.com/register/ )

comment:2 Changed 11 years ago by lemon-head

In fact I had already (think it was yesterday) started a class SignupPage based on RoxPageView. I mostly copied the stuff done by Felix, and used the RoxPageView mechanics to get a teaser, footer and other decorations. So, nothing really innovative, just a structural frame for further work.

I stopped the work, wondering if I could improve the PostHandling? mechanism, so we would not have to touch the post handler singleton from within our applications.

I hope we can soon make a decision if we want to keep using the RoxPageView stuff. (which would better be called RoxDefaultPage?).

comment:3 Changed 11 years ago by lemon-head

[4593] - conversion to new framework scheme.

comment:4 Changed 11 years ago by lemon-head

  • Milestone changed from unassigned to Applications using Rox Framework

comment:5 Changed 11 years ago by lemon-head

I think we should have all the fields in one column, not two. Filling a form is a linear process, so multi-column would only add confusion.

comment:6 Changed 11 years ago by philipp

  • Milestone changed from Applications using Rox Framework to 0.5.2-long

Milestone Applications using Rox Framework deleted

comment:7 Changed 10 years ago by lemon-head

  • Keywords hot added
  • Priority changed from major to critical

This really needs our attention! There are people having problems to sign up using the old page. Especially, the location selection sucks.

comment:8 Changed 10 years ago by micha

  • follow_up changed from none to test
  • Owner set to micha
  • Status changed from new to assigned

Philipp and me finally got our hands on this. We changed the latest signup by lemon-head to the new simple-style layout and made a 4-step process. We still have some errors to fix but basically it works. See r5659

comment:9 Changed 10 years ago by micha

also related: r5660 / #315

comment:10 Changed 10 years ago by micha

more commits: r5661 and r5662

comment:11 Changed 10 years ago by micha

and last one for tonight: r5663

comment:12 Changed 10 years ago by philipp

collecting feedback from other signup related tickets and closing them:

#518


04/09/08 11:43:18 changed by midsch ¶

this is a bit opposite to: http://www.bevolunteer.org/trac/ticket/505 (reduces the usage of scripts) 04/09/08 12:25:13 changed by lemon-head ¶

The solution is to do both php and javascript checks. This way, we don't depend on the javascript, but still make it more comfortable for people with js switched on.

I think the signup page does already have some very basic js checks (which fields are empty), but of course it can be improved. 04/09/08 20:31:00 changed by fake51 ¶

If the actual password check is to take place in javascript then I would say no. It is pure madness to send password-details through to the browser. Perhaps the idea is to send the login-details through ajax to avoid a page-reload - but honestly, that is way too much work for too little gain. 04/09/08 23:13:57 changed by lemon-head ¶

There are some things which can be checked quite well with javascript.

  • Is some information still missing, fields left empty? These fields can get a special highlight.
  • Does the date of birth have a valid format?
  • etc.

It is not an exotic idea to check these things with javascript, to make it a bit more comfortable for people.

Some websites even check the security level of the chosen password.. but I don't think we need this.

#105


(this can be started when other problems on the signup page are fixed!)

Currently the SignupPage on test.bewelcome.org can be quite frustrating.

Problem:

  • How to handle invalid user input?

Solutions:

  • Where possible, detect invalid input when typing, and display a live error indication next to the input textfield.
  • If the user sends a form with invalid input, then present the form again, but
    • with all the input fields unmodified
    • one message on top
    • a colored indication and message next to each input field where information is missing.
  • When the user sends a form with no invalid input, show a *confirm page*. With one button to confirm, another to go back and correct. The important fields are highlighted on the confirm page.
  • Get rid of unpleasant javascript alerts, whereever possible!

comment:13 Changed 10 years ago by philipp

some more work on the location selector ( http://test.bewelcome.org/signup/3 )for the signup (and in future other) applications

  • no shows the region in the suggested Places
  • returns the names in the language of the BW page (not working for all languages), english when translation does not exist in bw
  • further cleanup and fine tuning needed
  • please check if it is too slow (it makes up to 11 queries to geonames)

comment:14 Changed 10 years ago by philipp

Even with the new signup as it is in test right now we will have the problem that people fail to signup because:

  • their city is not in Geonames Database
  • they don't have a Street

Both are still mandatory and it has been decided to keep them mandatory

To allow completion of signup I suggest to add tickboxes above the feedback form:

  • I could not find my city
  • At my place we don't use the concept of street names

In case you tick on or both you should enter additional information into the feedback form. At the same time the checking those options would allow to leave the Street field empty and would set your lokation to Unknown (a special GeonameId? that does only exist in our database).

The signup/geo volunteers will then accept this member and try (after accepting him) to set the the right city (probably by adding it to geonames) or getting back to the member and deciging for some near by location.

comment:15 Changed 10 years ago by micha

Yeah, yeah, yeah! I just saw your work on the location selector. That's great! A vast improvement[[BR]]
Your proposal for non-found locations makes sense to me. However I would prefer to add the first tickbox only in the message that appears upon searching for a location. Otherwise it gets crowded again. About the street names: Is it really needed? Feedback like this could go into the feedback form..

comment:16 Changed 10 years ago by philipp

about selecting the location.

we display up to ten hits but often there are many more matches.

How about adding a link "there are 26 more Places, check them" that would execute a new query to geonames and display the result in a dropdown selection field (thereby not messing up the layout)

comment:17 Changed 10 years ago by micha

thumbs up! That's a good idea philipp. I will work on this.

comment:18 Changed 10 years ago by philipp

Wow, wow wow, great!

some minor comments:

  • change the position of the green tick (probably right after the text or in front of the number, probably even put a different background for the selected location)
  • Remove the text "more locations, show them" when they are displayed
  • make the location field yellow (as it is a required field)
  • we should rename the username and password fields (in the form) to avoid taking / changing your browser stored password

comment:19 Changed 10 years ago by philipp

a reminder from the forum, we need to make sure that your data is stored at any time:

Quote when you send the first sign on confirmation e-mail, please mention that the new member should not (in any case!) fill in her/his profile before having got this second welcome mail below. because exactly this is what i did last night. i spent (no lie!) at least 2 hours, filled in my profile as detailed as possible and luckily pushed the "enter" button, but then did not believe my eyes... ok, in the mail there had been written that you do not have full access to all features, but, hey, who would expect that one can ENTER them in the form, but not CONFIRM? so, maybe, it would be a good idea to just add one sentence to the first mail explaining this.

comment:20 Changed 10 years ago by micha

Some questions to your comments:

  • Why should the location field be yellow? I haven't seen that for any other field
  • A different background is already choosen for the selected location. It's just a light #f5f5f5 greyish color

I agree on renaming the username/password fields and the other stuff you proposed.

About the reminder: Didn't we solve that problem by using session-vars, at least for the signup itself? I'm not sure about the way for editing your profile though..

comment:21 Changed 10 years ago by philipp

  • Cc micha philipp added; steinwinde removed

some things I encountered:

  • characters like + should be allowed in e-mail
  • for password / e-mail and their confirmation fields the first one should be marked as valid even when the second one has not yet been entered but if it by itself is valid (long enough, a mail)
  • if you have a non valid mail or password and go on to the confirm page you first get only one field displayed to change, than you have to confirm and then change the confirmation field again, instead, both fields should be displayed at the same time
  • there are still those mysterious yellow fields (for me in ff3 as well) - lets see if I can hunt them down
  • form is finally submitted as soon as there is no error anymore (so I might not get the confirmation page, or might not be able to go back) - the final submit should only happen from regform4
  • the mail sending stuff needs to be taken care of

comment:22 Changed 10 years ago by philipp

it must be possible to select a location with javascript disabled

comment:23 Changed 10 years ago by micha

  • I don't understand why characters like + should be allowed. Also never saw and email address with +
  • password/email fields have been fixed (are independent now)

comment:24 Changed 10 years ago by philipp

From wikipedia http://en.wikipedia.org/wiki/E-mail_address

The local-part of the e-mail address may use any of these ASCII characters:

  • Uppercase and lowercase letters
  • Digits 0 through 9
  • Characters ! # $ % * / ? | { } ` ~ & ' + - = _
  • Character . provided that it is not the first nor last character, nor may it appear two or more times consecutively.

The + is for example used by gmail to generate several aliases for the same account

comment:25 Changed 10 years ago by globetrotter_tt

a bit more feedback:

  • is it really necessary, to enter the email address twice? It makes sense for fields where the user can not see what he is typing, like the passport, but for visible fields ??
  • Should we add short explaining texts for the fields again? (i.e. username should have min. 4 characters ?) The introduction text should be also changed, as we don't have the question marks behind the fields anymore.
  • The "back" link on page 2 looks not that nice, yet
  • Maybe the "search location" button looks better if it's arranged to the right of the input field.
  • It's a pity that we still require the complete address from every member, but this is a different discussion....
  • The mousepointer changes to "text-mode" when you click on the suggested locations. Is this wanted?
  • Maybe the red text for wrong entries on page 4 is a bit "squeezed" between the fields.

comment:26 Changed 10 years ago by philipp

still to be done:

  • make location selection non JS compatible

comment:27 Changed 10 years ago by micha

  • Cc globetrotter_tt added

Matthias, could you try to make the CSS perfect for the signup pages. This is really important and I won't be able to work on this for the next 4 weeks.

comment:28 Changed 10 years ago by midsch

Obsolete? http://test.bewelcome.org/signup/register with errors:

Warning: SignupPage::require(templates/registerformregister.php) [function.SignupPage-require]: failed to open stream: No such file or directory in /var/www/test.bewelcome.org/build/signup/signup.page.php on line 124
Fatal error: SignupPage::require() [function.require]: Failed opening required 'templates/registerformregister.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/test.bewelcome.org/build/signup/signup.page.php on line 124

This one: http://test.bewelcome.org/signup/ with enabled JS (the checker for the formfields is just to annoying; like netscapes blink-tag ... anyway as long as there is no signup without script, testing a fancy JS-solution isn't on the list.):

  • http://test.bewelcome.org/signup/1
    • no footnotes for "*" (same on the other pages)
    • Is re-typing or an mailadress clever? I tend to copy&paste it anyway.
  • http://test.bewelcome.org/signup/2
    • "back" is just a link, not a button like "next" (same on the other pages)
  • http://test.bewelcome.org/signup/3
    • As Philipp has already mentioned: No location without JS
    • "Please provide your Zip number/Postal Code (enter 0 if you have none)" - This is only to annoy people, isn't it? (As an irish postman told me once: "you know, my colleagues all can read. so what's the use for zip codes?") - Funny enough: "0" isn't working.
  • http://test.bewelcome.org/signup/4
    • the array with error messages is shown below submit-button (similar with other mistakes):
      array(3) { [0]=>  string(26) "SignupErrorProvideLocation" [1]=>  string(21) "SignupErrorProvideZip" [2]=>  string(21) "SignupMustacceptTerms" }
      
    • If you use an invalid mail and/or user name you can change here; if you do so after the next submit you get an error message that the re-type of mail/name doesn't fit (that's true, but you can't change it in the first step). To be honest: I've no idea how to solve it and re-type it (see screenshot).
    • Warning if there is no house number, but no chance to correct it.

Changed 10 years ago by midsch

Screenshot with confusing form fields

comment:29 Changed 10 years ago by midsch

  • follow_up changed from test to review code

comment:30 Changed 10 years ago by micha

changes in r6117, non-js geo-selection

comment:31 Changed 10 years ago by micha

  • follow_up changed from review code to test

new version of geo-selection and signup is online since r6119, please test again signup!

comment:32 Changed 10 years ago by micha

I think, this belongs also here:

lets give it a last thorough test and collect what is need before it can go online:

  • the signup itself seems to be pretty much done
  • the var_dump() on signup/4 very end of the page needs to be removed
  • views for cities and regions tables need to be configured and tested
  • new geo needs to be tested to be sure that it is really working
  • check that mandatory info displayed (*) and required by coded is identical
  • add the geo selction mechanism to updatemandatory (otherwise people can not change their address after geo/signup release)

comment:33 Changed 10 years ago by micha

So, this is still needed:

  • the var_dump() on signup/4 very end of the page needs to be removed
  • views for cities and regions tables need to be configured and tested
  • new geo needs to be tested to be sure that it is really working --> what does that mean?
  • check that mandatory info displayed -->what does that mean?
  • add the geo selction mechanism to updatemandatory (otherwise people can not change their address after geo/signup release) --> right, but couldn´t we just put this somewhere on the mainpage already? I think the location will change quite often.

comment:34 Changed 10 years ago by micha

So, this is still needed:

  • the var_dump() on signup/4 very end of the page needs to be removed
  • views for cities and regions tables need to be configured and tested
  • new geo needs to be tested to be sure that it is really working --> what does that mean?
  • check that mandatory info displayed -->what does that mean?
  • add the geo selction mechanism to updatemandatory (otherwise people can not change their address after geo/signup release) --> right, but couldn´t we just put this somewhere on the mainpage already? I think the location will change quite often.

comment:35 Changed 10 years ago by philipp

# check that mandatory info displayed -->what does that mean?

  • right now not every field that has an asterisk (*) is seen as mandatory in the code and others that are required by the code lack the asterisk:
    • location has no asterisk (add the asterisk)
    • zip has no asterisk but is mandatory in the code (either add the asterisk or change the code)
  • mail address is checked as ok by js while entering but shown as invalid in the final check (tested for my private gmail)

new geo needs to be tested to be sure that it is really working --> what does that mean?

  • the signup is based on a completely new geo application including big changes in the db model (see #691) - so we need to make sure that this is fully working

comment:36 follow-up: Changed 10 years ago by philipp

more testing of the singup:

  • the js based location selector does not show a map marker
  • I get two warnings after submitting on the /finish page
       Warning: Missing argument 2 for SignupView::style(), called in /var/www/test.bewelcome.org/build/signup/signup.view.php on line 349 and defined in /var/www/test.bewelcome.org/build/signup/signup.view.php on line 410
       Notice: Undefined variable: photo in /var/www/test.bewelcome.org/build/signup/signup.view.php on line 412
    
  • all my test accounts do not show up in MailToConfirm? and Pending
  • the name is public by default (and there is no option during signup to hide it)
  • right after signup displaying the location is not working on the profile - this is most likely due to some delay the region / city view needs to be updated (have to ask JY how long this is)
  • after confirming my mail I end up on a login page but I can not login until I am accepted - this is misleading as you get the impression that something with the signup went wrong - I would try to create a new account if I would not know better.

comment:37 Changed 10 years ago by philipp

  • the notification message still ends up in the inbox of the wannabe member (or is there some mail address hardcoded that sends me all singup notifications on test?)
  • the mail address of the new member is included in the notification massage sent to the signup team, this is probably bad as one would just need to relay all notification messages to some other address to get hold of all new singuped mail addresses and it is not really needed, please remove

Message sent to the wannabe member:

comment:38 in reply to: ↑ 36 Changed 10 years ago by micha

Replying to philipp:

more testing of the singup:

  • the js based location selector does not show a map marker

Actually the marker is shown but not in the center of the map. I found out that this is due to a CSS problem that we have to fix.

  • I get two warnings after submitting on the /finish page
       Warning: Missing argument 2 for SignupView::style(), called in /var/www/test.bewelcome.org/build/signup/signup.view.php on line 349 and defined in /var/www/test.bewelcome.org/build/signup/signup.view.php on line 410
       Notice: Undefined variable: photo in /var/www/test.bewelcome.org/build/signup/signup.view.php on line 412
    }}}[[BR]]
    

Fixed.

I noticed the same. Seems to be a problem with adminaccepter though. Maybe due to the geo-changes because there is no country stored with the member yet.

  • the name is public by default (and there is no option during signup to hide it)

I'll see if we can fix this.

  • after confirming my mail I end up on a login page but I can not login until I am accepted - this is misleading as you get the impression that something with the signup went wrong - I would try to create a new account if I would not know better.

Ideally that could be improved by enabling pending members to log in and just make it impossible for them to write messages.

comment:39 follow-up: Changed 10 years ago by micha

more bugfixes in r6125

Things that haven't been fixed:

  • the js based location selector does not show a map marker

registered members are now set by default to "NeedMore?" Status and can therefore login but not send messages.

  • the name is public by default (and there is no option during signup to hide it)
  • right after signup displaying the location is not working on the profile - this is most likely due to some delay the region / city view needs to be updated (have to ask JY how long this is)

comment:40 in reply to: ↑ 39 Changed 10 years ago by globetrotter_tt

Replying to micha:

more bugfixes in r6125

Things that haven't been fixed:

  • the js based location selector does not show a map marker

It shows a marker, but the centering of the map is not correct. (try and move the map until you find the marker) Maybe we should also show the world instead Zürich by default here ?

comment:41 Changed 10 years ago by micha

@globetrotter: Can't you try to fix the CSS maybe so that the map centers correctly? You're better than me with that. I believe this problem is due to alignment problems.

more bugfixes in r6143, signup views for mailing cleaned up. We could still add HTML-versions of the signup mails.

comment:42 Changed 10 years ago by micha

moved to alpha in r6148 for testing

We still have to fix the map.

comment:43 Changed 10 years ago by lemon-head

Thank you guys!! I really like the new signup! I was at first sceptical about having it split to different pages, but now I think it's a good idea.

There are some small issues, and some bigger ones...

  • Validation should happen after each step, not when you are finished, imo.
  • Signup should be more tolerant with usernames. For instance, it did not accept "lemon-head-test" - maybe because of the '-' symbol?
  • Select boxes for year and month should be bigger, so the text is not cut off (tested in Opera)
  • On the location picker page, the street name / number / Zip is pushed to the right once the search results show up. It gets partly hidden behind the right page border. (I guess you know that already)

comment:44 Changed 10 years ago by philipp

  • Validation should happen after each step, not when you are finished, imo.
    • in most cases you have immediate validation by js, so I think this is good enough (at least for now)
  • Signup should be more tolerant with usernames. For instance, it did not accept "lemon-head-test" - maybe because of the '-' symbol?
    • immediate check by js does allow this username, final check not - we have to make sure that both checks do the same thing (and allow this username)
  • Select boxes for year and month should be bigger, so the text is not cut off (tested in Opera)
    • fine one ff3 - thanks for reporting
  • On the location picker page, the street name / number / Zip is pushed to the right once the search results show up. It gets partly hidden behind the right page border. (I guess you know that already)
    • hm seems to be again a opera problem, thanks for reporting

comment:45 Changed 10 years ago by micha

  • follow_up changed from test to release

everything seems to work on alpha, let's move it to production? Geo first! > #315

comment:46 follow-up: Changed 10 years ago by micha

  • freq_reported changed from 1 to >10
  • version changed from test to all

comment:47 in reply to: ↑ 46 Changed 10 years ago by globetrotter_tt

  • follow_up changed from release to test on alpha

Replying to micha:

i just tried to sign up from alpha, using IE6 and got following error after submitting the form:

MySQL error!
PException

code:  1000 
message:  MySQL error! 
file:  /home/bwrox/alpha.bewelcome.org/lib/db/db_statement_mysql.lib.php 
line:  291 

info[0]: Statement: INSERT INTO `user` (`id`, `auth_id`, `handle`, `email`, `pw`, `active`) VALUES ( 2508, 1, 'globetestkerikeri', 'globetrotter_tt@gmx.net', password('password'), 0 )
info[1]: 1062
info[2]: Duplicate entry '2508' for key 1

i am afraid there is more testing needed and i would like to see all open issues to be fixed before it goes live. This weekend i have finally a bit time. I could help to fix the layout stuff.

comment:48 Changed 10 years ago by micha

This is definitely a problem that has to be solved before. It seems to be an issue that only exists on the alpha/live DB. On test we didn*t see this error at all.

comment:49 Changed 10 years ago by micha

latest changes in r6212 (on alpha already) (doesn't touch the MySQL-problem above)

comment:50 Changed 10 years ago by globetrotter_tt

some more small changes with r6231 (not on alpha, yet)

comment:51 Changed 10 years ago by midsch

-> location setting:

Works only with Cookies, but there is no hint for the user. Even if guess it by yourself and enable cookies, you have to send the form twice before you get a choice for a location.

comment:52 Changed 10 years ago by midsch

After getting through all the (useless) checks and (unnecessary) mandatory data with firefox 3.03 (though iceweasel here) and pressing submit i get the following error message on http://alpha.bewelcome.org/signup/4:

CRITICAL: password is unencrypted in error message! (This isn't via SSL!)

MySQL error!

PException
code: 	1000
message: 	MySQL error!
file: 	/home/bwrox/alpha.bewelcome.org/lib/db/db_statement_mysql.lib.php
line: 	291

info[0]: Statement: INSERT INTO `TESTFORUM.cryptedfields` ( `AdminCryptedValue`, `MemberCryptedValue`, `IsCrypted`, `IdMember`, `ToDo` ) VALUES ( 'spam@spam.com', 'spam@spam.com', 'not crypted', 5890, 'nothing' )
info[1]: 1103
info[2]: Incorrect table name 'TESTFORUM.cryptedfields'
PDBStatement_mysql::query( string(203) = " INSERT INTO `TESTFO"

INSERT INTO `TESTFORUM.cryptedfields`
(
	`AdminCryptedValue`,
	`MemberCryptedValue`,
	`IsCrypted`,
	`IdMember`,
	`ToDo`
)
VALUES
(
	'spam@spam.com',
	'spam@spam.com',
	'not crypted',
	5890,
	'nothing'
)

)
/home/bwrox/alpha.bewelcome.org/lib/db/db_mysql.lib.php (line 299)
PDB_mysql::query( string(203) = " INSERT INTO `TESTFO"

INSERT INTO `TESTFORUM.cryptedfields`
(
	`AdminCryptedValue`,
	`MemberCryptedValue`,
	`IsCrypted`,
	`IdMember`,
	`ToDo`
)
VALUES
(
	'spam@spam.com',
	'spam@spam.com',
	'not crypted',
	5890,
	'nothing'
)

)
/home/bwrox/alpha.bewelcome.org/build/signup/signup.model.php (line 512)
SignupModel::insertData( string(13) = "spam@spam.com"

spam@spam.com

, string 5890

5890

)
/home/bwrox/alpha.bewelcome.org/build/signup/signup.model.php (line 431)
SignupModel::registerBWMember( array[33]

Array
(
    [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
    [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
    [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
    [javascriptactive] => false
    [username] => spam
    [password] => spamspam
    [passwordcheck] => spamspam
    [email] => spam@spam.com
    [firstname] => spam: 
    [secondname] => 
    [lastname] => spam: 
    [birthyear] => 1990
    [birthmonth] => 1
    [birthday] => 1
    [gender] => female
    [street] => dadfs
    [housenumber] => adfaf
    [zip] => 
    [geonameid] => 2888092
    [latitude] => 52.1333333
    [longitude] => 10.7
    [geonamename] => Klein Vahlberg
    [countryname] => Germany
    [geonamecountrycode] => de
    [admincode] => Lower Saxony
    [newgeo] => 0
    [errors] => Array
        (
            [0] => SignupMustacceptTerms
        )

    [feedback] => adfaf
    [terms] => on
    [iso_date] => 1990-1-1
    [agehidden] => No
    [genderhidden] => No
    [IdCity] => 2888092
)

)
/home/bwrox/alpha.bewelcome.org/build/signup/signup.ctrl.php (line 226)
SignupController::signupFormCallback( stdClass object

stdClass Object
(
    [request_uri] => /signup/4
    [request] => Array
        (
            [0] => signup
            [1] => 4
        )

    [req] => signup/4
    [get] => Array
        (
        )

    [post] => Array
        (
            [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
            [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
            [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
            [javascriptactive] => false
            [username] => spam
            [email] => spam@spam.com
            [firstname] => spam: 
            [secondname] => 
            [lastname] => spam: 
            [birthday] => 1
            [birthmonth] => 1
            [birthyear] => 1990
            [gender] => female
            [geonameid] => 2888092
            [zip] => 
            [street] => dadfs
            [housenumber] => adfaf
            [latitude] => 52.1333333
            [longitude] => 10.7
            [geonamename] => Klein Vahlberg
            [countryname] => Germany
            [geonamecountrycode] => de
            [admincode] => Lower Saxony
            [feedback] => adfaf
            [terms] => on
        )

    [get_or_post] => Array
        (
            [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
            [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
            [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
            [javascriptactive] => false
            [username] => spam
            [email] => spam@spam.com
            [firstname] => spam: 
            [secondname] => 
            [lastname] => spam: 
            [birthday] => 1
            [birthmonth] => 1
            [birthyear] => 1990
            [gender] => female
            [geonameid] => 2888092
            [zip] => 
            [street] => dadfs
            [housenumber] => adfaf
            [latitude] => 52.1333333
            [longitude] => 10.7
            [geonamename] => Klein Vahlberg
            [countryname] => Germany
            [geonamecountrycode] => de
            [admincode] => Lower Saxony
            [feedback] => adfaf
            [terms] => on
        )

    [post_or_get] => Array
        (
            [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
            [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
            [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
            [javascriptactive] => false
            [username] => spam
            [email] => spam@spam.com
            [firstname] => spam: 
            [secondname] => 
            [lastname] => spam: 
            [birthday] => 1
            [birthmonth] => 1
            [birthyear] => 1990
            [gender] => female
            [geonameid] => 2888092
            [zip] => 
            [street] => dadfs
            [housenumber] => adfaf
            [latitude] => 52.1333333
            [longitude] => 10.7
            [geonamename] => Klein Vahlberg
            [countryname] => Germany
            [geonamecountrycode] => de
            [admincode] => Lower Saxony
            [feedback] => adfaf
            [terms] => on
        )

)

, ReadOnlyObject object

ReadOnlyObject Object
(
    [_values:private] => Array
        (
            [classname] => SignupController
            [methodname] => signupFormCallback
            [count] => 0
            [mem_resend] => ReadWriteObject Object
                (
                    [_values:private] => Array
                        (
                        )

                )

            [redirect_req] => 
            [mem_from_recovery] => 
        )

)

, ReadWriteObject object

ReadWriteObject Object
(
    [_values:private] => Array
        (
        )

)

, ReadWriteObject object

ReadWriteObject Object
(
    [_values:private] => Array
        (
        )

)

)
/home/bwrox/alpha.bewelcome.org/tools/routing/roxfrontrouter.class.php (line 140)
RoxFrontRouter::route_normal( stdClass object

stdClass Object
(
    [request_uri] => /signup/4
    [request] => Array
        (
            [0] => signup
            [1] => 4
        )

    [req] => signup/4
    [get] => Array
        (
        )

    [post] => Array
        (
            [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
            [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
            [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
            [javascriptactive] => false
            [username] => spam
            [email] => spam@spam.com
            [firstname] => spam: 
            [secondname] => 
            [lastname] => spam: 
            [birthday] => 1
            [birthmonth] => 1
            [birthyear] => 1990
            [gender] => female
            [geonameid] => 2888092
            [zip] => 
            [street] => dadfs
            [housenumber] => adfaf
            [latitude] => 52.1333333
            [longitude] => 10.7
            [geonamename] => Klein Vahlberg
            [countryname] => Germany
            [geonamecountrycode] => de
            [admincode] => Lower Saxony
            [feedback] => adfaf
            [terms] => on
        )

    [get_or_post] => Array
        (
            [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
            [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
            [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
            [javascriptactive] => false
            [username] => spam
            [email] => spam@spam.com
            [firstname] => spam: 
            [secondname] => 
            [lastname] => spam: 
            [birthday] => 1
            [birthmonth] => 1
            [birthyear] => 1990
            [gender] => female
            [geonameid] => 2888092
            [zip] => 
            [street] => dadfs
            [housenumber] => adfaf
            [latitude] => 52.1333333
            [longitude] => 10.7
            [geonamename] => Klein Vahlberg
            [countryname] => Germany
            [geonamecountrycode] => de
            [admincode] => Lower Saxony
            [feedback] => adfaf
            [terms] => on
        )

    [post_or_get] => Array
        (
            [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
            [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
            [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
            [javascriptactive] => false
            [username] => spam
            [email] => spam@spam.com
            [firstname] => spam: 
            [secondname] => 
            [lastname] => spam: 
            [birthday] => 1
            [birthmonth] => 1
            [birthyear] => 1990
            [gender] => female
            [geonameid] => 2888092
            [zip] => 
            [street] => dadfs
            [housenumber] => adfaf
            [latitude] => 52.1333333
            [longitude] => 10.7
            [geonamename] => Klein Vahlberg
            [countryname] => Germany
            [geonamecountrycode] => de
            [admincode] => Lower Saxony
            [feedback] => adfaf
            [terms] => on
        )

)

)
/home/bwrox/alpha.bewelcome.org/tools/routing/roxfrontrouter.class.php (line 24)
RoxFrontRouter::route( stdClass object

stdClass Object
(
    [request_uri] => /signup/4
    [request] => Array
        (
            [0] => signup
            [1] => 4
        )

    [req] => signup/4
    [get] => Array
        (
        )

    [post] => Array
        (
            [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
            [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
            [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
            [javascriptactive] => false
            [username] => spam
            [email] => spam@spam.com
            [firstname] => spam: 
            [secondname] => 
            [lastname] => spam: 
            [birthday] => 1
            [birthmonth] => 1
            [birthyear] => 1990
            [gender] => female
            [geonameid] => 2888092
            [zip] => 
            [street] => dadfs
            [housenumber] => adfaf
            [latitude] => 52.1333333
            [longitude] => 10.7
            [geonamename] => Klein Vahlberg
            [countryname] => Germany
            [geonamecountrycode] => de
            [admincode] => Lower Saxony
            [feedback] => adfaf
            [terms] => on
        )

    [get_or_post] => Array
        (
            [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
            [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
            [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
            [javascriptactive] => false
            [username] => spam
            [email] => spam@spam.com
            [firstname] => spam: 
            [secondname] => 
            [lastname] => spam: 
            [birthday] => 1
            [birthmonth] => 1
            [birthyear] => 1990
            [gender] => female
            [geonameid] => 2888092
            [zip] => 
            [street] => dadfs
            [housenumber] => adfaf
            [latitude] => 52.1333333
            [longitude] => 10.7
            [geonamename] => Klein Vahlberg
            [countryname] => Germany
            [geonamecountrycode] => de
            [admincode] => Lower Saxony
            [feedback] => adfaf
            [terms] => on
        )

    [post_or_get] => Array
        (
            [posthandler_callback_id] => 56DtIpQ6rdihOWWc=Qe8zJCnslQ
            [posthandler_callback_classname] => 6DDiBzJnmTb=4HbaIvQJbexCyGW
            [posthandler_callback_methodname] => biG1CvvUpva7dU1eFx2TKjNWZse
            [javascriptactive] => false
            [username] => spam
            [email] => spam@spam.com
            [firstname] => spam: 
            [secondname] => 
            [lastname] => spam: 
            [birthday] => 1
            [birthmonth] => 1
            [birthyear] => 1990
            [gender] => female
            [geonameid] => 2888092
            [zip] => 
            [street] => dadfs
            [housenumber] => adfaf
            [latitude] => 52.1333333
            [longitude] => 10.7
            [geonamename] => Klein Vahlberg
            [countryname] => Germany
            [geonamecountrycode] => de
            [admincode] => Lower Saxony
            [feedback] => adfaf
            [terms] => on
        )

)

)
/home/bwrox/alpha.bewelcome.org/roxlauncher/roxlauncher.php (line 61)
RoxLauncher::chooseAndRunApplication( EnvironmentExplorer object

EnvironmentExplorer Object
(
    [classes] => Array
        (
        )

)

)
/home/bwrox/alpha.bewelcome.org/roxlauncher/roxlauncher.php (line 22)
RoxLauncher::launch()
/home/bwrox/alpha.bewelcome.org/htdocs/index.php (line 62)

A reload (with resending the data) loads the page with the following result: "Username spam is already in use!"

  • I can't choose another one at this point
  • Going back to "Login information" at http://alpha.bewelcome.org/signup/1 I can change the name, but going back to "summary" doesn't take it
  • "next step" eats the new name, following through the steps doing "Submit" at the end ...

... ends up in another error message, resending it with the same result - probably the first time the username is already send to the DB, so a second attempt finds it already in use.

This should go back to test, it's not alpha.

comment:53 Changed 10 years ago by micha

Sorry midsch, but that problem only exists on alpha. On test we don´t have it. The mysql-message will be prevented once the signup is fully working on alpha/production. It's only on for bug-tracking currently.
About Cookies: As far as I know, you're not able to login at BW without cookies anyway. So having Cookies enabled is a must for registration. People that have cookies disabled are usually informed about the fact that a page want´s to store a cookie. If they don´t enable notification, I think it´s rather their problem, not ours.

comment:54 Changed 10 years ago by midsch

Ok, if the problem isn't on test, it's still there on alpha and has to be fixed.

About Cookies: As far as I know, you're not able to login at BW without cookies anyway. So having Cookies enabled is a must for registration. People that have cookies disabled are usually informed about the fact that a page want´s >to store a cookie. If they don´t enable notification, I think it´s rather their problem, not ours.

Sorry, but this is arrogant and ignorant bullshit. You don't have to enable the notifications for cookies (and if you try, you'll see why it's better not do so: it's quite annoying), if you want to keep your privacy you usally block all cookies and use a cookie manager to allow it for some sides (you "need" below 10% percent of the cookies even without beeing paranoid, than it's below 1%;). In an internet cafe cookies are usually allowed, but I would switch it off and the user after me just didn't know about it. So he/she's lost at BW, so there should always be a hint, that a side isn't working without cookies (js, flash, whatever), and it's good style to provide a message, i. e. at the beginning of signup like "To proceed you need to enable cookies for www.bewelcome.org" (and a link to a short explaination of the bw-usage of cookies, if I remember right it's already in FAQ). Doesn't cost anything but helps to limit technical help requests and signup failures.

What's about SSL? Shouldn't we force it for signup - at least as long as we ask for private data like adress, birth date and so on?

comment:55 Changed 10 years ago by feuerdaemon

works on FF 3.0.3 @ Kubuntu. Tested on alpha Only at the "Congratulations!-page" I get a Notice:

Notice: Undefined variable: max in /var/www/test.bewelcome.org/build/geo/geo.model.php on line 158

By the way: Login process is not proved against "back and forward"-clicks! It would maybe good, to fetch that to. (?)

Great work so far.

comment:56 Changed 10 years ago by feuerdaemon

Sorry I've tested @ "test.bw" not at "alpha.bw"

comment:57 Changed 10 years ago by micha

@feuerdaemon: Thanks for the feedback! I found the reason for the bug above (Notice: Undefined variable: max in /var/www/test.bewelcome.org/build/geo/geo.model.php on line 158). It's an easy fix and I just applied it to test and alpha. I don't really get what you mean with the "back and forward" links. We save all the data upon each commit (or in other ways upon each click on "next"). Data should not get lost when clicking on a "back" button.

@midsch: Sorry for my ignorant comment. But we still have to compare this signup with the current. The cookie problem doesn't exist for many users I would say. However you are totally right in saying that we shouldn't let them down anyway. I will follow your suggestion and add a sentence about cookies in the text above the signup.

About SSL: Again, this is right. We should enable it, but it comes after a working signup for me. I will try to set this up at least for sending the forms asap.

comment:58 Changed 10 years ago by micha

fix on alpha in r6357

comment:59 Changed 10 years ago by feuerdaemon

@micha: I meant with "back and forward", if you use your back and forward buttons from the browser. Kind of similar to the reload thing.

comment:60 follow-up: Changed 10 years ago by globetrotter_tt

  • follow_up changed from test on alpha to review code

finally i managed to signup on alpha :-)

Important: I created two profile on the same PC. The second time all data from the first profile i created were still in the forms. On page 3 i clicked the submit button but instead seing the summary page, like on the first time, i got to the "Congratulation..." page. Shouln't all data be delete after submitting/cancelling the signupform ? Or is this just my browser?

comment:61 in reply to: ↑ 60 Changed 10 years ago by globetrotter_tt

  • follow_up changed from review code to test on alpha

Replying to globetrotter_tt:

finally i managed to signup on alpha :-)

Important: I created two profile on the same PC. The second time all data from the first profile i created were still in the forms. On page 3 i clicked the submit button but instead seing the summary page, like on the first time, i got to the "Congratulation..." page. Shouln't all data be delete after submitting/cancelling the signupform ? Or is this just my browser?

seems it was fixed in r6364

comment:62 Changed 10 years ago by micha

  • follow_up changed from test on alpha to none
  • Resolution set to fixed
  • Status changed from assigned to closed

We did it. moved to production in several commits.

Note: See TracTickets for help on using tickets.