Ticket #499 (new unknown)
refactor: menu should be in one file
| Reported by: | guaka | Owned by: | guaka |
|---|---|---|---|
| Priority: | minor | Milestone: | unassigned |
| Component: | unknown | Keywords: | refactor, menu |
| Cc: | lupochen |
Description
Refactor: menu should be in one file
Now (almost) the same stuff is in topmenu.php, page_2col.php and page_index.php
Change History
comment:2 Changed 4 years ago by guaka
- Keywords refactor, menu added
Yeah, we use both, which I found out through #472...
comment:3 Changed 4 years ago by globetrotter_tt
Can you give an example where page_2col.php and page_index.php are used. i just want to save you from unecessary work ;)
comment:4 Changed 4 years ago by lemon-head
There is even one more place, which is:
- class PageWithRoxLayout?
- file tools/page/page-with-rox-layout.page.php
- on trac: http://www.bevolunteer.org/trac/browser/trunk/tools/page/page-with-rox-layout.page.php
comment:5 Changed 4 years ago by lemon-head
Btw, if we want we can quickly get rid of page.php, with not much changes. We just need to use this one instead, in the RoxFrontRouter?:
- class PageWithParameterizedRoxLayout? extends PageWithRoxLayout?
- tools/page/page-with-parameterized-rox-layout.page.php
- http://www.bevolunteer.org/trac/browser/trunk/tools/page/page-with-parameterized-rox-layout.page.php
Note: See
TracTickets for help on using
tickets.



Do we use page_2col.php and page_index.php anymore anywhere ? As far as i know not.
please correct me if i am wrong