Opened 11 years ago

Closed 6 years ago

#499 closed task (wontfix)

refactor: menu should be in one file

Reported by: guaka Owned by: guaka
Priority: minor Milestone: unassigned
Component: BW Layout Keywords: refactor, menu
Cc: lupochen

Description

Refactor: menu should be in one file

Now (almost) the same stuff is in topmenu.php, page_2col.php and page_index.php

Change History (10)

comment:1 Changed 11 years ago by globetrotter_tt

  • Cc lupochen added

Do we use page_2col.php and page_index.php anymore anywhere ? As far as i know not.

please correct me if i am wrong

comment:2 Changed 11 years ago by guaka

  • Keywords refactor menu added

Yeah, we use both, which I found out through #472...

comment:3 Changed 11 years ago by globetrotter_tt

Can you give an example where page_2col.php and page_index.php are used. i just want to save you from unecessary work ;)

comment:4 Changed 11 years ago by lemon-head

There is even one more place, which is:

comment:5 Changed 11 years ago by lemon-head

Btw, if we want we can quickly get rid of page.php, with not much changes. We just need to use this one instead, in the RoxFrontRouter?:

comment:6 Changed 10 years ago by guaka

r4885, deleted page_2col.php (which has been commented out for a week now)

comment:7 Changed 10 years ago by guaka

page_index.php can probably be removed as well, but I'm not sure yet, so commenting it out in r4886

comment:8 Changed 6 years ago by TimLoal

  • Component changed from unknown to BW Layout
  • Type changed from unknown to developer task

comment:9 Changed 6 years ago by jsfan

  • Milestone Future deleted

Milestone Future deleted

comment:10 Changed 6 years ago by guaka

  • Milestone set to unassigned
  • Resolution set to wontfix
  • Status changed from new to closed

Welen!

Note: See TracTickets for help on using tickets.