Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#614 closed bug (fixed)

It is possible to enter a language more than once.

Reported by: Sitarane Owned by: fake51
Priority: minor Milestone: new design bugfixing
Component: BW Profile Keywords: language, field, multiple, doblon, mothertongue, expert
Cc:

Description

At the time I checked it, this profile : https://www.bewelcome.org/bw/member.php?cid=neo82 had the language "Deutsch" as mothertongue and the language "deutsch" (the same) as expert. It should be made sure you can enter a language only once.

Change History (19)

comment:1 Changed 10 years ago by fake51

  • Owner set to fake51
  • Type changed from improve feature to bug

comment:2 Changed 10 years ago by fake51

  • follow_up changed from none to test

Should be fixed on test - have a go, see if you can enter the same language more than once. Please also check that selecting languages still works as normal.

comment:3 Changed 10 years ago by globetrotter_tt

When i tried it on test, i was not able to select a language that i had already selected before, but i could only select one more new language with one submit.

It should be possible to add as many languages you like without going back to "editmyprofile" every time.

Removing a language is still not possible We should also have much more languages in the select menu.

comment:4 Changed 10 years ago by fake51

I think there are existing tickets for the things you mention. Could you bump them up? If I have time I'll look into them then.

Btw, I don't think it's been possible to select languages twice for quite some time - however, you can fool the browser into submitting a language twice: with FireBug?, for instance, you can modify the value sent back to the server, so while you select one language, the server receives values matching a different one. That wasn't checked against before, which is what I fixed.

comment:5 Changed 10 years ago by crumbking

here the related tickets:

more languages: http://www.bevolunteer.org/trac/ticket/373

and

delete languages: http://www.bevolunteer.org/trac/ticket/372

and

easier way to add more than just one language (only on submit)http://www.bevolunteer.org/trac/ticket/128

comment:6 Changed 10 years ago by crumbking

(only one submit) I mean ;)

comment:7 Changed 9 years ago by crumbking

  • follow_up changed from test to review code
  • Milestone changed from unassigned to new design bugfixing
  • version set to production

seems like you can add more languages with one submit.

BUT I can't remove a language now. For testing I added chineese (expert) but there is no way to remove it now.

comment:8 Changed 9 years ago by fake51

  • follow_up changed from review code to test

I've changed the code that deals with choosing languages. It's on test now and needs both testing and some layout :)

comment:9 Changed 9 years ago by crumbking

go an error after the submit.

could it be that I removed my mother tongue -> German?

error: Fatal error: Call to a member function deleteMembersLanguages() on a non-object in /var/www/test.bewelcome.org/build/members/member.entity.php on line 1003

comment:10 Changed 9 years ago by fake51

Had missed a bit when updating test, should be working now, please try again

comment:11 Changed 9 years ago by crumbking

I tested before and it worked. Now I put my hands on it and well, guess it doesn't work anymore...

But layout is improved...

r8714

comment:12 Changed 9 years ago by fake51

Should be working on test now

comment:13 Changed 9 years ago by crumbking

  • follow_up changed from test to move to alpha

I tested again and it worked both ways. Adding and removing languages.

move to alpha.

comment:14 Changed 9 years ago by fake51

  • follow_up changed from move to alpha to test on alpha

It's on alpha now, works for me so far. Please give it a good testing :)

comment:15 Changed 9 years ago by crumbking

  • follow_up changed from test on alpha to release

works on alpha.

move to live.

comment:16 Changed 9 years ago by globetrotter_tt

works for me on production and it's much easier to handle now. Thank you!

comment:17 Changed 9 years ago by crumbking

fixed

comment:18 Changed 9 years ago by crumbking

  • Resolution set to fixed
  • Status changed from new to closed

comment:19 Changed 9 years ago by crumbking

  • follow_up changed from release to none
Note: See TracTickets for help on using tickets.